Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 401923004: Update isolate files for content tests and enable swarming for them. (Closed)

Created:
6 years, 5 months ago by jam
Modified:
6 years, 5 months ago
Reviewers:
M-A Ruel, sky
CC:
chromium-reviews, darin-cc_chromium.org
Project:
chromium
Visibility:
Public.

Description

Update isolate files for content tests and enable swarming for them. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284736

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -16 lines) Patch
M build/all.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_browsertests.isolate View 1 2 3 4 3 chunks +14 lines, -13 lines 0 comments Download
M content/content_tests.gypi View 1 1 chunk +14 lines, -0 lines 0 comments Download
M content/content_unittests.isolate View 1 2 3 4 5 3 chunks +3 lines, -1 line 0 comments Download
M testing/buildbot/chromium_trybot.json View 1 chunk +12 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
jam
content_unittests seems unable to start on Windows bots. How can I debug or try to ...
6 years, 5 months ago (2014-07-20 21:14:22 UTC) #1
M-A Ruel
On 2014/07/20 21:14:22, jam wrote: > content_unittests seems unable to start on Windows bots. How ...
6 years, 5 months ago (2014-07-21 15:47:47 UTC) #2
jam
On 2014/07/21 15:47:47, M-A Ruel wrote: > On 2014/07/20 21:14:22, jam wrote: > > content_unittests ...
6 years, 5 months ago (2014-07-21 16:22:39 UTC) #3
M-A Ruel
On 2014/07/21 16:22:39, jam wrote: > On 2014/07/21 15:47:47, M-A Ruel wrote: > > On ...
6 years, 5 months ago (2014-07-21 17:14:22 UTC) #4
jam
ah, looks like the bug was that I wrote os_mesa.dll instead of osmesa.dll in the ...
6 years, 5 months ago (2014-07-21 18:20:08 UTC) #5
M-A Ruel
lgtm
6 years, 5 months ago (2014-07-22 16:18:58 UTC) #6
jam
The CQ bit was checked by jam@chromium.org
6 years, 5 months ago (2014-07-22 16:30:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/401923004/140001
6 years, 5 months ago (2014-07-22 16:31:48 UTC) #8
jam
+sky for testing/buildbot owners
6 years, 5 months ago (2014-07-22 17:05:05 UTC) #9
sky
LGTM
6 years, 5 months ago (2014-07-22 17:22:27 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-22 18:25:51 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 18:29:58 UTC) #12
Message was sent while issue was closed.
Change committed as 284736

Powered by Google App Engine
This is Rietveld 408576698