IndexedDB: Stop using webkit-prefixed versions of APIs in tests

IndexedDB: Stop using webkit-prefixed versions of APIs in test scripts

We "dropped" the prefix well over a year ago and would like to deprecate/remove from Blink when we can.

webkitIndexedDB -> indexedDB
webkitIDBFooBar -> IDBFooBar

Also, correct uses of the long removed errorCode and webkitErrorMessage properties on IDBRequest (now
just error.name and error.message).

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284711

[jsbell, 2014-07-18 19:03:46]

cmumford, michaeln - PTAL?

[michaeln, 2014-07-18 21:45:48]

lgtm

[jsbell, 2014-07-18 21:50:29]

The CQ bit was checked by jsbell@chromium.org

[commit-bot: I haz the power, 2014-07-18 21:52:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jsbell@chromium.org/401893002/1

[cmumford, 2014-07-18 21:55:29]

https://codereview.chromium.org/401893002/diff/1/content/test/data/indexeddb/...
File content/test/data/indexeddb/transaction_test.js (left):

https://codereview.chromium.org/401893002/diff/1/content/test/data/indexeddb/...
content/test/data/indexeddb/transaction_test.js:73: indexedDB = webkitIndexedDB;
So is the goal of this test to stop using 'webkitIndexedDB' everywhere? If so
then there are uses in other files not in this CL.

[jsbell, 2014-07-18 22:27:25]

The CQ bit was unchecked by jsbell@chromium.org

[jsbell, 2014-07-18 22:27:49]

On 2014/07/18 21:55:29, cmumford wrote:
>
https://codereview.chromium.org/401893002/diff/1/content/test/data/indexeddb/...
> File content/test/data/indexeddb/transaction_test.js (left):
> 
>
https://codereview.chromium.org/401893002/diff/1/content/test/data/indexeddb/...
> content/test/data/indexeddb/transaction_test.js:73: indexedDB =
webkitIndexedDB;
> So is the goal of this test to stop using 'webkitIndexedDB' everywhere?

Yes. Ideally we'd remove it; initially we'll deprecate (which we should have
done nearly 2 years ago, but ah well...)

> If so then there are uses in other files not in this CL.

Pri 1 would be places that *depend* on it. Pri 2 would be removing the rest even
if harmless.

Crud, yeah, there's one in ui/file_manager that *depends* on it. *sigh*. Will
fix and re-up.

[jsbell, 2014-07-18 22:49:04]

hirono@ - OWNERS review of ui/file_manager change?

[jsbell, 2014-07-18 22:49:28]

And cmumford@ - can you take a look at the rest? Not as trivial as I thought,
alas.

[cmumford, 2014-07-18 23:08:57]

On 2014/07/18 22:27:49, jsbell wrote:
> On 2014/07/18 21:55:29, cmumford wrote:
> >
>
https://codereview.chromium.org/401893002/diff/1/content/test/data/indexeddb/...
> > File content/test/data/indexeddb/transaction_test.js (left):
> > 
> >
>
https://codereview.chromium.org/401893002/diff/1/content/test/data/indexeddb/...
> > content/test/data/indexeddb/transaction_test.js:73: indexedDB =
> webkitIndexedDB;
> > So is the goal of this test to stop using 'webkitIndexedDB' everywhere?
> 
> Yes. Ideally we'd remove it; initially we'll deprecate (which we should have
> done nearly 2 years ago, but ah well...)
> 
> > If so then there are uses in other files not in this CL.
> 
> Pri 1 would be places that *depend* on it. Pri 2 would be removing the rest
even
> if harmless.
> 
> Crud, yeah, there's one in ui/file_manager that *depends* on it. *sigh*. Will
> fix and re-up.

OK. So here's my understanding. You want to remove all cases where the test
won't gracefully fallback to the proper W3C name "i.e. indexedDB/IDBFooBar. I'll
review under that assumption and let me know if that's wrong.

[jsbell, 2014-07-18 23:25:22]

On 2014/07/18 23:08:57, cmumford wrote:
> OK. So here's my understanding. You want to remove all cases where the test
> won't gracefully fallback to the proper W3C name "i.e. indexedDB/IDBFooBar.
I'll
> review under that assumption and let me know if that's wrong.

Sounds good, but an even strong assertion - no use at all of the prefixed names.
I put more notes in the description.

(The exception is the nonstandard webkitGetDatabaseNames API)

[cmumford, 2014-07-18 23:30:23]

lgtm

[hirono, 2014-07-22 00:22:55]

lgtm for file_manger.

[jsbell, 2014-07-22 00:57:07]

The CQ bit was checked by jsbell@chromium.org

[commit-bot: I haz the power, 2014-07-22 00:58:32]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jsbell@chromium.org/401893002/20001

[commit-bot: I haz the power, 2014-07-22 01:48:51]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[commit-bot: I haz the power, 2014-07-22 01:53:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-22 01:53:06]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[jsbell, 2014-07-22 16:45:09]

tonyg@ - OWNERS approval for the tools/perf/page_sets/endure update?

[tonyg, 2014-07-22 16:45:50]

lgtm

[jsbell, 2014-07-22 16:56:17]

The CQ bit was checked by jsbell@chromium.org

[commit-bot: I haz the power, 2014-07-22 16:57:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jsbell@chromium.org/401893002/20001

[commit-bot: I haz the power, 2014-07-22 17:02:08]

Change committed as 284711