Mojo: Drive-by include fixes.

Mojo: Drive-by include fixes.

R=yzshen@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284216

[yzshen1, 2014-07-18 20:52:49]

LGTM with one nit.

https://codereview.chromium.org/401883003/diff/20001/mojo/public/cpp/bindings...
File mojo/public/cpp/bindings/lib/array_serialization.h (right):

https://codereview.chromium.org/401883003/diff/20001/mojo/public/cpp/bindings...
mojo/public/cpp/bindings/lib/array_serialization.h:8: #include <string.h>  //
For |memcpy()|.
nit, optional: I think it is no need to explain why we need an include. It gets
out of sync easily (e.g., someone adds a call to another function in string.h).

[viettrungluu, 2014-07-18 20:59:33]

Thanks.

https://codereview.chromium.org/401883003/diff/20001/mojo/public/cpp/bindings...
File mojo/public/cpp/bindings/lib/array_serialization.h (right):

https://codereview.chromium.org/401883003/diff/20001/mojo/public/cpp/bindings...
mojo/public/cpp/bindings/lib/array_serialization.h:8: #include <string.h>  //
For |memcpy()|.
On 2014/07/18 20:52:49, yzshen1 wrote:
> nit, optional: I think it is no need to explain why we need an include. It
gets
> out of sync easily (e.g., someone adds a call to another function in
string.h).

Generally, I agree with you, but since the requirement for string.h isn't quite
so obvious, it makes it very easy to accidentally remove this include (since in
reality string.h always gets included from somewhere).

(Presumably, if someone calls something else in string.h, they'd first check
that string.h is included, and notice that it is and remove/update the comment.
Admittedly, "ideally" is probably more true than "presumably"....)

[viettrungluu, 2014-07-18 20:59:37]

The CQ bit was checked by viettrungluu@chromium.org

[yzshen1, 2014-07-18 21:01:26]

https://codereview.chromium.org/401883003/diff/20001/mojo/public/cpp/bindings...
File mojo/public/cpp/bindings/lib/array_serialization.h (right):

https://codereview.chromium.org/401883003/diff/20001/mojo/public/cpp/bindings...
mojo/public/cpp/bindings/lib/array_serialization.h:8: #include <string.h>  //
For |memcpy()|.
Okay. I don't have a string opinion on this one.

[commit-bot: I haz the power, 2014-07-18 21:01:59]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/401883003/20001

[viettrungluu, 2014-07-18 22:14:17]

Committed patchset #2 manually as r284216 (presubmit successful).