Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 401843002: DevTools: Change RemoteObject._describe method for Errors (Closed)

Created:
6 years, 5 months ago by kozyatinskiy1
Modified:
6 years, 5 months ago
Reviewers:
vsevik, aandrey
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Change RemoteObject._describe method for Errors Earlier this method returns class name for errors objects, now it returns className + ':' + error.message. R=vsevik@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178462

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -14 lines) Patch
M LayoutTests/inspector/console/console-dir-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/inspector/console/console-format-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/inspector/console/console-save-to-temp-var-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/sources/debugger/async-callstack-scopes-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/inspector/sources/debugger/debugger-expand-scope-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InjectedScriptSource.js View 2 chunks +8 lines, -3 lines 1 comment Download

Messages

Total messages: 7 (0 generated)
kozyatinskiy1
@vsevik, ptal.
6 years, 5 months ago (2014-07-18 15:48:45 UTC) #1
vsevik
lgtm
6 years, 5 months ago (2014-07-18 16:03:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kozyatinskiy@google.com/401843002/1
6 years, 5 months ago (2014-07-18 16:04:52 UTC) #3
aandrey
https://codereview.chromium.org/401843002/diff/1/Source/core/inspector/InjectedScriptSource.js File Source/core/inspector/InjectedScriptSource.js (right): https://codereview.chromium.org/401843002/diff/1/Source/core/inspector/InjectedScriptSource.js#newcode1047 Source/core/inspector/InjectedScriptSource.js:1047: if (obj instanceof Error && !!obj.message) obj.message can throw
6 years, 5 months ago (2014-07-18 16:10:30 UTC) #4
aandrey
On 2014/07/18 16:10:30, aandrey wrote: > https://codereview.chromium.org/401843002/diff/1/Source/core/inspector/InjectedScriptSource.js > File Source/core/inspector/InjectedScriptSource.js (right): > > https://codereview.chromium.org/401843002/diff/1/Source/core/inspector/InjectedScriptSource.js#newcode1047 > ...
6 years, 5 months ago (2014-07-18 16:12:40 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_blink_compile_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-18 17:07:12 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 17:22:17 UTC) #7
Message was sent while issue was closed. 
Change committed as 178462

Powered by Google App Engine
This is Rietveld 408576698