Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 401823002: Added IsConstructorCall to gin::Arguments. (Closed)

Created:
6 years, 5 months ago by Krzysztof Olczyk
Modified:
6 years, 5 months ago
CC:
chromium-reviews, Mostyn Bramley-Moore
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Added IsConstructorCall to gin::Arguments. It simply forwards the flag from v8::FunctionCallbackInfo and allows the function handler that accept gin::Arguments argument to distinguish between normal function invocation and call as an object construction. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284123

Patch Set 1 #

Patch Set 2 : Unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -2 lines) Patch
M gin/arguments.h View 1 chunk +4 lines, -0 lines 0 comments Download
M gin/arguments.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M gin/wrappable_unittest.cc View 1 2 chunks +27 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Krzysztof Olczyk
Hi abarth, jochen, could you take a look at this tiny addition to gin::Arguments?
6 years, 5 months ago (2014-07-18 12:28:39 UTC) #1
jochen (gone - plz use gerrit)
On 2014/07/18 12:28:39, Krzysztof Olczyk wrote: > Hi abarth, jochen, > > could you take ...
6 years, 5 months ago (2014-07-18 12:29:47 UTC) #2
Krzysztof Olczyk
On 2014/07/18 12:29:47, jochen wrote: > On 2014/07/18 12:28:39, Krzysztof Olczyk wrote: > > Hi ...
6 years, 5 months ago (2014-07-18 12:40:39 UTC) #3
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-18 13:07:25 UTC) #4
Krzysztof Olczyk
The CQ bit was checked by kolczyk@opera.com
6 years, 5 months ago (2014-07-18 13:09:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kolczyk@opera.com/401823002/20001
6 years, 5 months ago (2014-07-18 13:10:20 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 16:46:18 UTC) #7
Message was sent while issue was closed.
Change committed as 284123

Powered by Google App Engine
This is Rietveld 408576698