Optimize algorithm for String.prototype.repeat(), fix value caching in others

src/harmony-string.js

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 // This file relies on the fact that the following declaration has been made
 // in runtime.js:
 // var $String = global.String;
 // var $Array = global.Array;
 
 // -------------------------------------------------------------------
 
 // ES6 draft 01-20-14, section 21.1.3.13
 function StringRepeat(count) {
   CHECK_OBJECT_COERCIBLE(this, "String.prototype.repeat");
 
   var s = TO_STRING_INLINE(this);
   var n = ToInteger(count);
   if (n < 0 || !NUMBER_IS_FINITE(n)) {
     throw MakeRangeError("invalid_count_value", []);
   }
 
-  var elements = new InternalArray(n);
-  for (var i = 0; i < n; i++) {
-    elements[i] = s;
+  // O(log n) algorithm
+
+  if (n < 1) return '';

[aandrey, 2014/07/30 09:04:01]

nit: use ""

+
+  var res = '';
+
+  while (n > 1) {

[aandrey, 2014/07/30 09:04:01]

+1 for a simpler version, since string concatenations is far more heavy than a
comparison. e.g.

var res = "";
while (n) {
  if (n & 1) {
    res += s;
    --n;
  } else {
    s += s;
    n >>= 1;
  }
}
return res;

+      if (n & 1) res += s;
+      n >>= 1;
+      s += s;
   }
 
-  return %StringBuilderConcat(elements, n, "");
+  // unroll last iteration, no need to double the initial string again at the
+  // final iteration.
+  return res + s;
 }
 
 
 // ES6 draft 04-05-14, section 21.1.3.18
 function StringStartsWith(searchString /* position */) {  // length == 1
   CHECK_OBJECT_COERCIBLE(this, "String.prototype.startsWith");
 
   var s = TO_STRING_INLINE(this);
 
   if (IS_REGEXP(searchString)) {
     throw MakeTypeError("first_argument_not_regexp",
                         ["String.prototype.startsWith"]);
   }
 
   var ss = TO_STRING_INLINE(searchString);
   var pos = 0;
   if (%_ArgumentsLength() > 1) {
     pos = %_Arguments(1);  // position
     pos = ToInteger(pos);
   }
 
   var s_len = s.length;
   var start = MathMin(MathMax(pos, 0), s_len);
-  var ss_len = ss.length;
-  if (ss_len + start > s_len) {
+  if (ss.length + start > s_len) {

[aandrey, 2014/07/30 09:04:01]

this should be a separate patch, to ease possible rollbacks

     return false;
   }
 
   return %StringIndexOf(s, ss, start) === start;
 }
 
 
 // ES6 draft 04-05-14, section 21.1.3.7
 function StringEndsWith(searchString /* position */) {  // length == 1
   CHECK_OBJECT_COERCIBLE(this, "String.prototype.endsWith");
 
   var s = TO_STRING_INLINE(this);
 
   if (IS_REGEXP(searchString)) {
     throw MakeTypeError("first_argument_not_regexp",
                         ["String.prototype.endsWith"]);
   }
 
   var ss = TO_STRING_INLINE(searchString);
   var s_len = s.length;
   var pos = s_len;
   if (%_ArgumentsLength() > 1) {
     var arg = %_Arguments(1);  // position
     if (!IS_UNDEFINED(arg)) {
       pos = ToInteger(arg);
     }
   }
 
   var end = MathMin(MathMax(pos, 0), s_len);
-  var ss_len = ss.length;
-  var start = end - ss_len;
+  var start = end - ss.length;
   if (start < 0) {
     return false;
   }
 
   return %StringLastIndexOf(s, ss, start) === start;
 }
 
 
 // ES6 draft 04-05-14, section 21.1.3.6
 function StringContains(searchString /* position */) {  // length == 1
   CHECK_OBJECT_COERCIBLE(this, "String.prototype.contains");
 
   var s = TO_STRING_INLINE(this);
 
   if (IS_REGEXP(searchString)) {
     throw MakeTypeError("first_argument_not_regexp",
                         ["String.prototype.contains"]);
   }
 
   var ss = TO_STRING_INLINE(searchString);
   var pos = 0;
   if (%_ArgumentsLength() > 1) {
     pos = %_Arguments(1);  // position
     pos = ToInteger(pos);
   }
 
   var s_len = s.length;
   var start = MathMin(MathMax(pos, 0), s_len);
-  var ss_len = ss.length;
-  if (ss_len + start > s_len) {
+  if (ss.length + start > s_len) {
     return false;
   }
 
   return %StringIndexOf(s, ss, start) !== -1;
 }
 
 
 // ES6 Draft 05-22-2014, section 21.1.3.3
 function StringCodePointAt(pos) {
   CHECK_OBJECT_COERCIBLE(this, "String.prototype.codePointAt");
@@ skipping 56 matching lines @@
   InstallFunctions($String.prototype, DONT_ENUM, $Array(
     "codePointAt", StringCodePointAt,
     "contains", StringContains,
     "endsWith", StringEndsWith,
     "repeat", StringRepeat,
     "startsWith", StringStartsWith
   ));
 }
 
 ExtendStringPrototype();