Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Issue 401733002: No need to call InitGoogleMock() ourselves. (Closed)

Created:
6 years, 5 months ago by tfarina
Modified:
6 years, 5 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, eseidel, jamesr, jochen (gone - plz use gerrit)
Project:
blink
Visibility:
Public.

Description

No need to call InitGoogleMock() ourselves. base's TestSuite already does this for us, so we can just let it handle that detail, instead of doing this twice. BUG=None TEST=webkit_unit_tests R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178416

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M Source/web/tests/RunAllTests.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/web/tests/WebUnitTests.cpp View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tfarina
6 years, 5 months ago (2014-07-17 23:41:43 UTC) #1
abarth-chromium
lgtm
6 years, 5 months ago (2014-07-18 00:19:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/401733002/1
6 years, 5 months ago (2014-07-18 00:20:14 UTC) #3
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 02:14:37 UTC) #4
Message was sent while issue was closed.
Change committed as 178416

Powered by Google App Engine
This is Rietveld 408576698