Mojo: Log an error when we fail to find a JS module.

Mojo: Log an error when we fail to find a JS module.

BUG=328119
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285023

[Matt Perry, 2014-07-22 18:42:33]

ping

[abarth-chromium, 2014-07-22 19:31:01]

I'm not sure I understand the problem that you're trying to solve...  How do you
know when a module load has failed?  The module might appear later.

[Matt Perry, 2014-07-22 19:41:52]

On 2014/07/22 19:31:01, abarth wrote:
> I'm not sure I understand the problem that you're trying to solve...  How do
you
> know when a module load has failed?  The module might appear later.

The goal was to wait until everything is settled before logging the error. If
we've finished loading all modules, and we still have unsatisfied dependencies,
that means those dependencies couldn't be found, right?

[abarth-chromium, 2014-07-22 22:15:05]

On 2014/07/22 at 19:41:52, mpcomplete wrote:
> The goal was to wait until everything is settled before logging the error. If
we've finished loading all modules, and we still have unsatisfied dependencies,
that means those dependencies couldn't be found, right?

I don't think that's true in general.  For example, what if someone later calls
AddBuiltinModule?  I guess we don't call AttemptToLoadMoreModules after we add
the built-in module, but that's probably a bug...

[abarth-chromium, 2014-07-22 22:16:15]

https://codereview.chromium.org/401723002/diff/1/gin/modules/file_module_prov...
File gin/modules/file_module_provider.cc (right):

https://codereview.chromium.org/401723002/diff/1/gin/modules/file_module_prov...
gin/modules/file_module_provider.cc:47: callback.Run(false);
Maybe we should just log something at this point and not wait for the system to
stop churning?  We should probably be looking on disk last anyway.

[Matt Perry, 2014-07-22 22:24:40]

https://codereview.chromium.org/401723002/diff/1/gin/modules/file_module_prov...
File gin/modules/file_module_provider.cc (right):

https://codereview.chromium.org/401723002/diff/1/gin/modules/file_module_prov...
gin/modules/file_module_provider.cc:47: callback.Run(false);
On 2014/07/22 22:16:15, abarth wrote:
> Maybe we should just log something at this point and not wait for the system
to
> stop churning? We should probably be looking on disk last anyway.

Huh.. I thought I tried that and it resulted in false positives. But it seems to
work. That's way simpler. I'll do that.

[abarth-chromium, 2014-07-22 22:30:09]

LGTM

[Matt Perry, 2014-07-22 22:30:30]

The CQ bit was checked by mpcomplete@chromium.org

[commit-bot: I haz the power, 2014-07-22 22:32:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/401723002/20001

[commit-bot: I haz the power, 2014-07-23 02:20:59]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-07-23 04:22:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-23 04:22:52]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[Matt Perry, 2014-07-23 19:54:57]

The CQ bit was checked by mpcomplete@chromium.org

[commit-bot: I haz the power, 2014-07-23 19:57:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/401723002/20001

[commit-bot: I haz the power, 2014-07-23 20:03:56]

Change committed as 285023