Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 401693003: Notify Java O2TS when revoking all tokens. (Closed)

Created:
6 years, 5 months ago by acleung1
Modified:
6 years, 5 months ago
CC:
chromium-reviews, Roger Tawa OOO till Jul 10th
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Notify Java O2TS when revoking all tokens. During a forced signout (sync account removed from device), we signout without ever give the token service a chance to validate accounts. Without this CL, the AO2TS becomes out-of-sync with the device's account list. BUG=393037 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284218

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/browser/signin/android_profile_oauth2_token_service.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
acleung1
Hi Tommy. Roger is out for two more weeks. Would you mind taking a quick ...
6 years, 5 months ago (2014-07-17 21:06:54 UTC) #1
nyquist
lgtm. could you also move the BUG= line to be the last line in the ...
6 years, 5 months ago (2014-07-17 21:16:48 UTC) #2
acleung1
On 2014/07/17 21:16:48, nyquist wrote: > lgtm. could you also move the BUG= line to ...
6 years, 5 months ago (2014-07-17 21:46:27 UTC) #3
acleung1
The CQ bit was checked by acleung@chromium.org
6 years, 5 months ago (2014-07-17 21:46:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acleung@chromium.org/401693003/1
6 years, 5 months ago (2014-07-17 21:48:46 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-18 01:54:42 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-18 01:58:30 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/80769)
6 years, 5 months ago (2014-07-18 01:58:30 UTC) #8
acleung1
On 2014/07/18 01:58:30, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 5 months ago (2014-07-18 05:24:41 UTC) #9
tim (not reviewing)
lgtm
6 years, 5 months ago (2014-07-18 21:50:26 UTC) #10
acleung1
The CQ bit was checked by acleung@chromium.org
6 years, 5 months ago (2014-07-18 21:52:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acleung@chromium.org/401693003/1
6 years, 5 months ago (2014-07-18 21:54:19 UTC) #12
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 22:17:15 UTC) #13
Message was sent while issue was closed.
Change committed as 284218

Powered by Google App Engine
This is Rietveld 408576698