Correctly update the bounds of objects in the accessibility tree.

Correctly update the bounds of objects in the accessibility tree.

Fixes regression that happened when moving to the new AXTree code.
Improves on it by only sending location changes when there's an
AXLayoutChanged event, since that will always be fired when there's a
layout and objects might have moved.

To make it testable, adds a new feature to DumpAccessibilityTree tests
where you can make it wait until a certain magic string appears in the
dump before the dump is diffed with the expectation. In this test, we
start a CSS transition that animates changing a button's size, and make
sure the final dump reflects the final size.

BUG=268296
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285174

[dmazzoni, 2014-07-18 23:41:18]

+phajdan.jr for content/test

[aboxhall, 2014-07-19 15:08:05]

lgtm

https://codereview.chromium.org/401643003/diff/60001/content/browser/accessib...
File content/browser/accessibility/dump_accessibility_tree_browsertest.cc
(right):

https://codereview.chromium.org/401643003/diff/60001/content/browser/accessib...
content/browser/accessibility/dump_accessibility_tree_browsertest.cc:238: if
(wait_for.empty())
This if statement is redundant with the while statement immediately below, isn't
it?

https://codereview.chromium.org/401643003/diff/60001/content/renderer/accessi...
File content/renderer/accessibility/renderer_accessibility_complete.cc (right):

https://codereview.chromium.org/401643003/diff/60001/content/renderer/accessi...
content/renderer/accessibility/renderer_accessibility_complete.cc:175: bool
had_layout_complete_messages = false;
Why is this plural?

https://codereview.chromium.org/401643003/diff/60001/content/renderer/accessi...
content/renderer/accessibility/renderer_accessibility_complete.cc:257: //
Explore children of this object.
Oops! :)

https://codereview.chromium.org/401643003/diff/60001/content/test/data/access...
File content/test/data/accessibility/transition-expected-android.txt (right):

https://codereview.chromium.org/401643003/diff/60001/content/test/data/access...
content/test/data/accessibility/transition-expected-android.txt:1: #<skip -
Android doesn't output the location and size of objects.>
Really? Is that an issue with our DumpAccessibilityTree implementation on
Android?

[dmazzoni, 2014-07-20 04:24:17]

https://codereview.chromium.org/401643003/diff/60001/content/browser/accessib...
File content/browser/accessibility/dump_accessibility_tree_browsertest.cc
(right):

https://codereview.chromium.org/401643003/diff/60001/content/browser/accessib...
content/browser/accessibility/dump_accessibility_tree_browsertest.cc:238: if
(wait_for.empty())
On 2014/07/19 15:08:05, aboxhall wrote:
> This if statement is redundant with the while statement immediately below,
isn't
> it?

Oh, good point.

https://codereview.chromium.org/401643003/diff/60001/content/renderer/accessi...
File content/renderer/accessibility/renderer_accessibility_complete.cc (right):

https://codereview.chromium.org/401643003/diff/60001/content/renderer/accessi...
content/renderer/accessibility/renderer_accessibility_complete.cc:175: bool
had_layout_complete_messages = false;
On 2014/07/19 15:08:05, aboxhall wrote:
> Why is this plural?

There could be more than one "layout complete" in |src_events|.

https://codereview.chromium.org/401643003/diff/60001/content/renderer/accessi...
content/renderer/accessibility/renderer_accessibility_complete.cc:257: //
Explore children of this object.
On 2014/07/19 15:08:05, aboxhall wrote:
> Oops! :)

Yup! Accidentally lost when refactoring, easy fix, the hard part was coming up
with a good test so that this wouldn't regress in the future.

[aboxhall, 2014-07-21 01:33:47]

lgtm

https://codereview.chromium.org/401643003/diff/60001/content/renderer/accessi...
File content/renderer/accessibility/renderer_accessibility_complete.cc (right):

https://codereview.chromium.org/401643003/diff/60001/content/renderer/accessi...
content/renderer/accessibility/renderer_accessibility_complete.cc:175: bool
had_layout_complete_messages = false;
On 2014/07/20 04:24:17, dmazzoni wrote:
> On 2014/07/19 15:08:05, aboxhall wrote:
> > Why is this plural?
> 
> There could be more than one "layout complete" in |src_events|.
> 

Obviously not a deal-breaker, but to me had_layout_complete_message meaning "at
least one" makes more sense than "had_layout_complete_messages" meaning "one or
more". Totally up to you though!

[dmazzoni, 2014-07-22 21:07:42]

+jcivelli for content/test ???

[Paweł Hajdan Jr., 2014-07-23 10:36:51]

LGTM

[dmazzoni, 2014-07-23 14:08:48]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2014-07-23 14:10:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/401643003/80001

[commit-bot: I haz the power, 2014-07-23 14:28:11]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/9...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/20...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel_swarming on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_sw...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win8_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/32061)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/36899)

[commit-bot: I haz the power, 2014-07-23 14:30:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-23 14:30:11]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)

[dmazzoni, 2014-07-24 06:38:09]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2014-07-24 06:40:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/401643003/100001

[commit-bot: I haz the power, 2014-07-24 10:41:20]

Change committed as 285174