|
Extract ScopedTestNSSDB from nss_util.
Before ScopedTestNSSDB affected several slot getters from nss_util.h .
This change reduces ScopedTestNSSDB to solely setup a temporary test DB and not influencing the global state in nss_util anymore.
As a replacement for some of its old behavior, a new ScopedTestSystemNSSKeySlot is added, which allows to override the slot returned by GetSystemNSSKeySlot().
With this change it's now possible to write tests that need both a user and system NSS DB by using ScopedTestSystemNSSKeySlot.
As a side-effect, GetPersistentNSSKeySlot() is now compiled on !OS_CHROMEOS only.
BUG= 210525
(For include changes:)
R=rsleevi@chromium.org
TBR=nkostylev@chromium.org, stevenjb@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285881
Total comments: 15
Total comments: 17
Total comments: 6
Total comments: 2
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+424 lines, -208 lines) |
Patch |
|
M |
chrome/browser/chromeos/login/auth/parallel_authenticator_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/chromeos/net/cert_verify_proc_chromeos_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/browser/chromeos/policy/policy_cert_verifier_browsertest.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
11
12
13
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chrome/chrome_browser.gypi
|
View
|
1
2
3
4
5
6
7
8
9
10
11
12
13
14
|
2 chunks |
+8 lines, -1 line |
0 comments
|
Download
|
|
M |
chrome/chrome_tests.gypi
|
View
|
1
2
3
4
5
6
7
8
9
10
11
12
13
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
chrome/chrome_tests_unit.gypi
|
View
|
1
2
3
4
5
6
7
8
9
10
11
12
13
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
chrome/common/net/x509_certificate_model_unittest.cc
|
View
|
1
2
|
3 chunks |
+11 lines, -13 lines |
0 comments
|
Download
|
|
M |
chromeos/cert_loader_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
9
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chromeos/chromeos.gyp
|
View
|
1
2
3
4
5
6
7
8
9
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
chromeos/network/client_cert_resolver_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
9
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chromeos/network/network_cert_migrator_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
9
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chromeos/network/network_connection_handler_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
9
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
chromeos/network/onc/onc_certificate_importer_impl_unittest.cc
|
View
|
1
2
3
4
5
6
7
8
9
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
crypto/BUILD.gn
|
View
|
1
2
3
4
5
6
7
8
9
10
11
12
13
|
3 chunks |
+34 lines, -0 lines |
0 comments
|
Download
|
|
M |
crypto/crypto.gyp
|
View
|
1
2
3
4
5
6
7
8
|
3 chunks |
+44 lines, -0 lines |
0 comments
|
Download
|
|
M |
crypto/nss_util.h
|
View
|
1
2
3
4
5
6
7
8
9
10
|
5 chunks |
+0 lines, -42 lines |
0 comments
|
Download
|
|
M |
crypto/nss_util.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
|
19 chunks |
+46 lines, -126 lines |
2 comments
|
Download
|
|
M |
crypto/nss_util_internal.h
|
View
|
1
2
3
4
|
3 chunks |
+25 lines, -4 lines |
0 comments
|
Download
|
|
M |
crypto/rsa_private_key_nss_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
A |
crypto/scoped_test_nss_chromeos_user.h
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+43 lines, -0 lines |
0 comments
|
Download
|
|
A |
crypto/scoped_test_nss_chromeos_user.cc
|
View
|
1
2
3
4
5
6
7
8
9
10
|
1 chunk |
+37 lines, -0 lines |
0 comments
|
Download
|
|
A |
crypto/scoped_test_nss_db.h
|
View
|
1
2
|
1 chunk |
+35 lines, -0 lines |
0 comments
|
Download
|
|
A |
crypto/scoped_test_nss_db.cc
|
View
|
1
2
|
1 chunk |
+48 lines, -0 lines |
0 comments
|
Download
|
|
A |
crypto/scoped_test_system_nss_key_slot.h
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+39 lines, -0 lines |
0 comments
|
Download
|
|
A |
crypto/scoped_test_system_nss_key_slot.cc
|
View
|
1
2
3
4
5
6
7
|
1 chunk |
+28 lines, -0 lines |
0 comments
|
Download
|
|
M |
net/BUILD.gn
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
net/base/keygen_handler_unittest.cc
|
View
|
|
2 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
|
M |
net/cert/nss_cert_database_chromeos_unittest.cc
|
View
|
1
2
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
net/cert/nss_cert_database_unittest.cc
|
View
|
1
2
3
4
5
6
7
|
3 chunks |
+6 lines, -7 lines |
0 comments
|
Download
|
|
M |
net/cert/nss_profile_filter_chromeos_unittest.cc
|
View
|
1
2
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
net/net.gyp
|
View
|
1
2
3
4
5
6
7
8
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
net/ssl/client_cert_store_chromeos_unittest.cc
|
View
|
1
2
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
Total messages: 39 (0 generated)
|