Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 401613004: Fix silly mistakes (Closed)

Created:
6 years, 5 months ago by oshima
Modified:
6 years, 5 months ago
Reviewers:
sadrul
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M athena/wm/window_manager_impl.cc View 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
oshima
6 years, 5 months ago (2014-07-17 14:24:35 UTC) #1
oshima
Committed patchset #2 manually as r283774 (presubmit successful).
6 years, 5 months ago (2014-07-17 14:26:06 UTC) #2
oshima
resource change was wrong. I *looked* worked, but I probably made some mistake. I'll wait ...
6 years, 5 months ago (2014-07-17 15:41:08 UTC) #3
sadrul
LGTM Sorry I missed this during the previous review.
6 years, 5 months ago (2014-07-17 16:34:49 UTC) #4
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 5 months ago (2014-07-17 17:22:49 UTC) #5
oshima
The CQ bit was unchecked by oshima@chromium.org
6 years, 5 months ago (2014-07-17 17:22:49 UTC) #6
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 5 months ago (2014-07-17 17:22:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/401613004/40001
6 years, 5 months ago (2014-07-17 17:25:07 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 20:18:26 UTC) #9
Message was sent while issue was closed.
Change committed as 283851

Powered by Google App Engine
This is Rietveld 408576698