Issue 401603003: Remove ActiveDOMObject::{,un}setPendingActivity

Issue 401603003: Remove ActiveDOMObject::{,un}setPendingActivity (Closed)

Created:
6 years, 5 months ago by kouhei (in TOK)

Modified:
6 years, 5 months ago

Reviewers:
haraken, tyoshino (SeeGerritForStatus), abarth-chromium

CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, ed+blinkwatch_opera.com, Michael van Ouwerkerk, rwlbuis, rune+blink, sof

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Remove ActiveDOMObject::{,un}setPendingActivity Now all invocation of {,un}setPendingActivity is gone! Removing them from ActiveDOMObject. The default implementation of hasPendingActivity is still left, as there are some classes deriving from ActiveDOMObject to receive suspend() and resume() notifications. BUG=354845 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178368

Patch Set 1 #

Patch Set 2 : rebased #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -22 lines)			Patch
M	Source/core/css/FontFaceSet.cpp	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	Source/core/dom/ActiveDOMObject.h	View	1	2 chunks	+0 lines, -18 lines	0 comments	Download
M	Source/core/dom/ActiveDOMObject.cpp	View	1	2 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 11 (0 generated)

Expand Messages | Collapse Messages

Michael van Ouwerkerk

On 2014/07/17 09:31:25, tyoshino wrote: > lgtm Would it make sense to also update this ...

6 years, 5 months ago (2014-07-17 09:35:52 UTC) #4

kouhei (in TOK)

On 2014/07/17 09:35:52, Michael van Ouwerkerk wrote: > On 2014/07/17 09:31:25, tyoshino wrote: > > ...

6 years, 5 months ago (2014-07-17 10:13:18 UTC) #5

kouhei (in TOK)

On 2014/07/17 10:13:18, kouhei wrote: > On 2014/07/17 09:35:52, Michael van Ouwerkerk wrote: > > ...

6 years, 5 months ago (2014-07-17 13:18:50 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/401603003/20001

6 years, 5 months ago (2014-07-17 13:19:39 UTC) #8

tyoshino (SeeGerritForStatus)

6 years, 5 months ago (2014-07-18 04:40:45 UTC) #11

Message was sent while issue was closed.

On 2014/07/17 13:18:50, kouhei wrote:
> On 2014/07/17 10:13:18, kouhei wrote:
> > On 2014/07/17 09:35:52, Michael van Ouwerkerk wrote:
> > > On 2014/07/17 09:31:25, tyoshino wrote:
> > > > lgtm
> > > 
> > > Would it make sense to also update this page?
> > > http://www.chromium.org/blink/activedomobject
> > 
> > Yes. However I don't have a edit permission for the page.
> 
> Edited.

Thanks. LG \o/

Expand Messages | Collapse Messages