Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 401583002: Revert of Drop NaCl dependencies on platforms where disable_nacl=1. (Closed)

Created:
6 years, 5 months ago by tzik
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert of Drop NaCl dependencies on platforms where disable_nacl=1. (https://codereview.chromium.org/321423002/) Reason for revert: This seems to cause build failure on disable_nacl=1 build. There are still some dependency to nacl_switches and nacl_module_handler like: src/chrome/browser/ui/startup/bad_flags_prompt.cc:46 src/chrome/browser/component_updater/pnacl/pnacl_component_installer.cc:376 src/chrome/browser/extensions/plugin_manager.cc:71 Original issue's description: > Drop NaCl dependencies on platforms where disable_nacl=1. > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283505 TBR=palmer@chromium.org, thestig@chromium.org, bradnelson@chromium.org NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -53 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 7 chunks +7 lines, -15 lines 0 comments Download
M chrome/chrome_common.gypi View 5 chunks +6 lines, -10 lines 0 comments Download
M chrome/common/BUILD.gn View 2 chunks +3 lines, -18 lines 0 comments Download
M chrome/common/all_messages.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common_constants.gyp View 2 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tzik
Created Revert of Drop NaCl dependencies on platforms where disable_nacl=1.
6 years, 5 months ago (2014-07-17 05:01:31 UTC) #1
tzik
The CQ bit was unchecked by tzik@chromium.org
6 years, 5 months ago (2014-07-17 05:01:56 UTC) #2
Lei Zhang
Did I break a bot somewhere?
6 years, 5 months ago (2014-07-17 05:04:41 UTC) #3
tzik
On 2014/07/17 05:04:41, Lei Zhang wrote: > Did I break a bot somewhere? No, it ...
6 years, 5 months ago (2014-07-17 05:11:13 UTC) #4
tzik
On 2014/07/17 05:11:13, tzik wrote: > On 2014/07/17 05:04:41, Lei Zhang wrote: > > Did ...
6 years, 5 months ago (2014-07-17 05:16:28 UTC) #5
tzik
On 2014/07/17 05:16:28, tzik wrote: > On 2014/07/17 05:11:13, tzik wrote: > > On 2014/07/17 ...
6 years, 5 months ago (2014-07-17 05:27:50 UTC) #6
Lei Zhang
On 2014/07/17 05:16:28, tzik wrote: > On 2014/07/17 05:11:13, tzik wrote: > > On 2014/07/17 ...
6 years, 5 months ago (2014-07-17 05:29:37 UTC) #7
tzik
6 years, 5 months ago (2014-07-17 05:47:03 UTC) #8
On 2014/07/17 05:29:37, Lei Zhang wrote:
> On 2014/07/17 05:16:28, tzik wrote:
> > On 2014/07/17 05:11:13, tzik wrote:
> > > On 2014/07/17 05:04:41, Lei Zhang wrote:
> > > > Did I break a bot somewhere?
> > > 
> > > No, it just break my local build with disable_nacl=1.
> > 
> > Should we stop reverting and fix it now?
> 
> Oh, you are doing a desktop build with disable_nacl turned on. Can we try to
fix
> it?
Yes, it's just for faster build. OK, so let's just fix without revert.

> 
> The code in pnacl_component_installer.cc is being removed:
> https://codereview.chromium.org/398213002/
> bad_flags_prompt.cc just needs a #ifdef.
> plugin_manager.cc might need a bit more work.

Powered by Google App Engine
This is Rietveld 408576698