Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 401553002: Introduce DEFINE_FONT_DATA_TYPE_CASTS, and use it (Closed)

Created:
6 years, 5 months ago by gyuyoung-inactive
Modified:
6 years, 5 months ago
Reviewers:
tkent
CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Introduce DEFINE_FONT_DATA_TYPE_CASTS, and use it As a step to use toFoo, this cl introduces DEFINE_FONT_DATA_TYPE_CASTS, and use it. In SegmentedFontData case, it already has own type cast macro. This cl removes it, and use DEFINE_FONT_DATA_TYPE_CASTS. BUG=309516 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178332

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : Patch for landing #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M Source/platform/fonts/FontData.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M Source/platform/fonts/FontFallbackList.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/fonts/GlyphPageTreeNode.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/platform/fonts/SegmentedFontData.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/SimpleFontData.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
gyuyoung-inactive
PTAL
6 years, 5 months ago (2014-07-17 01:56:54 UTC) #1
tkent
lgtm https://codereview.chromium.org/401553002/diff/1/Source/platform/fonts/FontFallbackList.cpp File Source/platform/fonts/FontFallbackList.cpp (right): https://codereview.chromium.org/401553002/diff/1/Source/platform/fonts/FontFallbackList.cpp#newcode74 Source/platform/fonts/FontFallbackList.cpp:74: FontCache::fontCache()->releaseFontData(toSimpleFontData(m_fontList[i].get())); DEFINE_FONT_DATA_TYPE_CASTS should take care of RefPtr argument, ...
6 years, 5 months ago (2014-07-17 02:29:16 UTC) #2
gyuyoung-inactive
https://codereview.chromium.org/401553002/diff/1/Source/platform/fonts/FontFallbackList.cpp File Source/platform/fonts/FontFallbackList.cpp (right): https://codereview.chromium.org/401553002/diff/1/Source/platform/fonts/FontFallbackList.cpp#newcode74 Source/platform/fonts/FontFallbackList.cpp:74: FontCache::fontCache()->releaseFontData(toSimpleFontData(m_fontList[i].get())); On 2014/07/17 02:29:16, tkent wrote: > DEFINE_FONT_DATA_TYPE_CASTS should ...
6 years, 5 months ago (2014-07-17 04:04:14 UTC) #3
gyuyoung-inactive
The CQ bit was checked by gyuyoung.kim@samsung.com
6 years, 5 months ago (2014-07-17 04:04:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/401553002/20001
6 years, 5 months ago (2014-07-17 04:05:25 UTC) #5
gyuyoung-inactive
The CQ bit was unchecked by gyuyoung.kim@samsung.com
6 years, 5 months ago (2014-07-17 04:16:58 UTC) #6
gyuyoung-inactive
The CQ bit was checked by gyuyoung.kim@samsung.com
6 years, 5 months ago (2014-07-17 04:19:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/401553002/40001
6 years, 5 months ago (2014-07-17 04:20:17 UTC) #8
gyuyoung-inactive
The CQ bit was unchecked by gyuyoung.kim@samsung.com
6 years, 5 months ago (2014-07-17 04:52:04 UTC) #9
gyuyoung-inactive
The CQ bit was checked by gyuyoung.kim@samsung.com
6 years, 5 months ago (2014-07-17 05:02:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/401553002/60001
6 years, 5 months ago (2014-07-17 05:03:45 UTC) #11
gyuyoung-inactive
> const SimpleFontData* found = static_cast<const SimpleFontData*>(CFDictionaryGetValue(m_derivedFontData->compositeFontReferences.get(), static_cast<const void *>(key))); toSimpleFontData() doesn't support CFDictionaryGetValue() return ...
6 years, 5 months ago (2014-07-17 05:05:45 UTC) #12
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 06:57:19 UTC) #13
Message was sent while issue was closed. 
Change committed as 178332

Powered by Google App Engine
This is Rietveld 408576698