Issue 401533002: Lower byte swap intrinsic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 401533002: Lower byte swap intrinsic. (Closed)

Created:
6 years, 5 months ago by jvoung (off chromium)

Modified:
6 years, 5 months ago

Reviewers:
Jim Stichnoth, wala

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Visibility:
Public.

Lower byte swap intrinsic. Clump the negate instruction w/ the bswap instruction as an "inplace" operation. One difference is that bswap has stricter requirements the operand type. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3882 R=stichnot@chromium.org, wala@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=7fa813b

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+171 lines, -60 lines)			Patch
M	crosstest/test_bitmanip.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	crosstest/test_bitmanip.cpp	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	crosstest/test_bitmanip.def	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	crosstest/test_bitmanip_main.cpp	View	1	3 chunks	+47 lines, -21 lines	0 comments	Download
M	src/IceInstX8632.h	View	1 2 3	6 chunks	+41 lines, -17 lines	0 comments	Download
M	src/IceInstX8632.cpp	View	1 2 3	4 chunks	+4 lines, -20 lines	0 comments	Download
M	src/IceTargetLoweringX8632.h	View	1 2 3	2 chunks	+6 lines, -0 lines	0 comments	Download
M	src/IceTargetLoweringX8632.cpp	View	1 2 3	1 chunk	+28 lines, -2 lines	0 comments	Download
M	tests_lit/llvm2ice_tests/nacl-other-intrinsics.ll	View		2 chunks	+30 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

jvoung (off chromium)

6 years, 5 months ago (2014-07-18 20:01:15 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r7fa813b (presubmit successful).