Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issue 40153003: AllocationProfiler: Inital version of RecordObjectAllocation for hydrogen. (Closed)

Created:
7 years, 2 months ago by loislo
Modified:
7 years, 1 month ago
CC:
v8-dev, yurys, alph
Visibility:
Public.

Description

AllocationProfiler: Inital version of RecordObjectAllocation for hydrogen. We are using hydrogen for stubs. So we would like to see the objects that were allocated from hydrogen. HAllocate has no enough information about memory chunks in the allocated memory fragment. As example JSArray allocates as a single memory fragment but it has inside three heap objects: array header, memento and fixed array for the elements. The only way to report them separately is to do that on hydrogen level from the place where we have the information about chunk sizes. BUG=none

Patch Set 1 #

Patch Set 2 : mips, ia32 and arm platforms were added #

Unified diffs Side-by-side diffs Delta from patch set Stats (+214 lines, -50 lines) Patch
M src/arm/lithium-arm.h View 1 2 chunks +14 lines, -0 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/assembler.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/code-stubs.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/heap-profiler.h View 3 chunks +5 lines, -4 lines 0 comments Download
M src/heap-profiler.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M src/hydrogen.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 1 4 chunks +37 lines, -9 lines 0 comments Download
M src/hydrogen-instructions.h View 1 2 chunks +27 lines, -0 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/ia32/lithium-ia32.h View 1 2 chunks +14 lines, -0 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/mips/lithium-mips.h View 1 2 chunks +14 lines, -0 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/x64/lithium-x64.h View 1 2 chunks +14 lines, -0 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 1 chunk +2 lines, -4 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 5 chunks +21 lines, -26 lines 0 comments Download
M test/cctest/cctest.h View 1 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
loislo
7 years, 2 months ago (2013-10-24 14:54:56 UTC) #1
loislo
7 years, 2 months ago (2013-10-24 15:10:34 UTC) #2
WIP

Powered by Google App Engine
This is Rietveld 408576698