Issue 40151: Fix _ValidateLists to work when running in linting mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 40151: Fix _ValidateLists to work when running in linting mode. (Closed)

Created:
11 years, 9 months ago by ojan

Modified:
9 years, 7 months ago

Reviewers:
Pam (message me for reviews)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix _ValidateLists to work when running in linting mode. In linting mode we don't walk the tree to find the list of actual test files, so we don't know the full paths to files. We just use prefix matching to look for duplicate files. So when validating the two test lists in linting mode, we should also use prefix matching.

Patch Set 1 #

Patch Set 2 : Fix 80 char violation #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -6 lines)			Patch
M	webkit/tools/layout_tests/layout_package/compare_failures.py	View		2 chunks	+5 lines, -2 lines	0 comments	Download
M	webkit/tools/layout_tests/layout_package/test_expectations.py	View	1	1 chunk	+20 lines, -2 lines	0 comments	Download
M	webkit/tools/layout_tests/run_webkit_tests.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Pam (message me for reviews)

11 years, 9 months ago (2009-03-05 03:21:00 UTC) #2

The log message is a little confusing. Should one of those "in linting mode"
pieces be "in real mode"? And the last sentence is hard to parse, too.

Otherwise LGTM.

Expand Messages | Collapse Messages