Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(985)

Issue 40149: Add performance tests for the proxy resolver implementations.... (Closed)

Created:
11 years, 9 months ago by eroman
Modified:
9 years, 6 months ago
Reviewers:
wtc
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add performance tests for the proxy resolver implementations. I downloaded the test data "no-ads.pac" from <http://ap.coova.org/wpad.dat>;. BUG=2764 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11066

Patch Set 1 #

Total comments: 22

Patch Set 2 : Address wtc's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1570 lines, -0 lines) Patch
M chrome/chrome.sln View 1 chunk +5 lines, -0 lines 0 comments Download
M net/base/ssl_test_util.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/build/net_perftests.vcproj View 1 chunk +4 lines, -0 lines 0 comments Download
A net/data/proxy_resolver_perftest/no-ads.pac View 1 chunk +1362 lines, -0 lines 0 comments Download
M net/net.sln View 1 chunk +4 lines, -0 lines 0 comments Download
A net/proxy/proxy_resolver_perftest.cc View 1 1 chunk +191 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
eroman
I ran this test, and the results were: ProxyResolverWinHttp_no-ads.pac 1818 ms ProxyResolverV8_no-ads.pac 70 ms Which ...
11 years, 9 months ago (2009-03-05 02:07:20 UTC) #1
wtc
LGTM. A nice wrapup of your excellent work on the V8 proxy resolver! Is the ...
11 years, 9 months ago (2009-03-05 19:04:54 UTC) #2
eroman
> Is the net_perftests not being built on Mac and Linux? > You didn't change ...
11 years, 9 months ago (2009-03-06 00:07:46 UTC) #3
wtc
11 years, 9 months ago (2009-03-06 00:18:49 UTC) #4
On 2009/03/06 00:07:46, eroman wrote:
> > Is the net_perftests not being built on Mac and Linux? 
> > You didn't change their build files.
> 
> Unfortunately neither the try server nor chromium builders build net_perftests
> (AFAICT).
> 
> Hence I am proceeding carefully to make sure I test the change on each
platform
> before adding.
> 
> This is a little more error prone process, so I would prefer to add as a
second
> CL. Is that OK?

Of course, it is.

LGTM!

Powered by Google App Engine
This is Rietveld 408576698