Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 401473002: Re-land "Add GN build targets for the rest of mojo/public" (Closed)

Created:
6 years, 5 months ago by Chris Masone
Modified:
6 years, 5 months ago
Reviewers:
brettw, yzshen1
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Re-land "Add GN build targets for the rest of mojo/public" Add GN build targets for the rest of mojo/public BUG=369643 TEST='gn gen out/Debug && ninja -C out/Debug mojo Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283697

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -6 lines) Patch
M mojo/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M mojo/mojo_public.gypi View 6 chunks +7 lines, -0 lines 0 comments Download
A + mojo/public/BUILD.gn View 1 chunk +12 lines, -2 lines 0 comments Download
A mojo/public/c/system/BUILD.gn View 1 chunk +28 lines, -0 lines 0 comments Download
A mojo/public/cpp/application/BUILD.gn View 1 chunk +22 lines, -0 lines 0 comments Download
A mojo/public/cpp/environment/BUILD.gn View 1 chunk +18 lines, -0 lines 0 comments Download
A mojo/public/cpp/utility/BUILD.gn View 1 chunk +28 lines, -0 lines 0 comments Download
A mojo/public/java/BUILD.gn View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Chris Masone
Ok, this doesn't have the problematic target anymore, as it actually depends on some stuff ...
6 years, 5 months ago (2014-07-16 22:08:11 UTC) #1
brettw
RS LGTM
6 years, 5 months ago (2014-07-17 04:35:01 UTC) #2
Chris Masone
The CQ bit was checked by cmasone@chromium.org
6 years, 5 months ago (2014-07-17 04:38:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmasone@chromium.org/401473002/1
6 years, 5 months ago (2014-07-17 04:43:00 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-17 07:28:30 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-17 07:32:02 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/80486)
6 years, 5 months ago (2014-07-17 07:32:04 UTC) #7
yzshen1
On 2014/07/17 07:32:04, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 5 months ago (2014-07-17 07:35:49 UTC) #8
yzshen1
The CQ bit was checked by yzshen@chromium.org
6 years, 5 months ago (2014-07-17 07:35:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmasone@chromium.org/401473002/1
6 years, 5 months ago (2014-07-17 07:37:03 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 07:45:47 UTC) #11
Message was sent while issue was closed.
Change committed as 283697

Powered by Google App Engine
This is Rietveld 408576698