Create NaCl build of gtest.

Create NaCl build of gtest.

Originally landed as 289216 and reverted as 289223 due to a GYP bug.

BUG=401761
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289558

[Nick Bray (chromium), 2014-07-18 21:55:57]

Ping.

https://codereview.chromium.org/401453002/diff/20001/testing/gtest_nacl.gyp
File testing/gtest_nacl.gyp (right):

https://codereview.chromium.org/401453002/diff/20001/testing/gtest_nacl.gyp#n...
testing/gtest_nacl.gyp:10: '../build/common_untrusted.gypi',
Should this go inside the condition?

[bradn, 2014-07-18 22:56:10]

lgtm

m

https://codereview.chromium.org/401453002/diff/20001/build/all.gyp
File build/all.gyp (right):

https://codereview.chromium.org/401453002/diff/20001/build/all.gyp#newcode28
build/all.gyp:28: '../testing/gtest_nacl.gyp:*',
I think this need to be gated on disable_nacl, but I may be mistaken.

https://codereview.chromium.org/401453002/diff/20001/testing/gtest_nacl.gyp
File testing/gtest_nacl.gyp (right):

https://codereview.chromium.org/401453002/diff/20001/testing/gtest_nacl.gyp#n...
testing/gtest_nacl.gyp:10: '../build/common_untrusted.gypi',
On 2014/07/18 21:55:57, Nick Bray (chromium) wrote:
> Should this go inside the condition?
No, I think includes can't be conditional.

https://codereview.chromium.org/401453002/diff/20001/testing/gtest_nacl.gyp#n...
testing/gtest_nacl.gyp:33: # In order to allow regex matches in gtest to be
shared between Windows
>80

[Nick Bray (chromium), 2014-08-12 23:14:48]

The CQ bit was checked by ncbray@chromium.org

[commit-bot: I haz the power, 2014-08-12 23:52:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ncbray@chromium.org/401453002/60001

[commit-bot: I haz the power, 2014-08-13 08:50:47]

Change committed as 289216

[Joao da Silva, 2014-08-13 09:01:48]

Going to revert this, broke the tree. See comment inline.

https://codereview.chromium.org/401453002/diff/60001/testing/gtest_nacl.gyp
File testing/gtest_nacl.gyp (right):

https://codereview.chromium.org/401453002/diff/60001/testing/gtest_nacl.gyp#n...
testing/gtest_nacl.gyp:48: 'defines': [
This key is duplicated from line 32

[Joao da Silva, 2014-08-13 09:02:10]

A revert of this CL (patchset #4) has been created in
https://codereview.chromium.org/461423002/ by joaodasilva@chromium.org.

The reason for reverting is: Broke the tree:

gyp: Key 'defines' repeated at level 6 with key path 'conditions.0.1.targets.0'
while reading /Volumes/data/b/build/slave/Mac/build/src/testing/gtest_nacl.gyp
.

[Nick Bray (chromium), 2014-08-13 17:24:45]

https://codereview.chromium.org/401453002/diff/60001/testing/gtest_nacl.gyp
File testing/gtest_nacl.gyp (right):

https://codereview.chromium.org/401453002/diff/60001/testing/gtest_nacl.gyp#n...
testing/gtest_nacl.gyp:48: 'defines': [
On 2014/08/13 09:01:48, Joao da Silva wrote:
> This key is duplicated from line 32

Yeah, I blindly const folded out a conditional and didn't notice the
duplication.  And this is why you don't use Python dicts as a DSL.  :/

What I don't understand is why two bots caught it, but nothing else did.

[Nick Bray (chromium), 2014-08-13 19:48:47]

Brad: PTAL

[bradn, 2014-08-13 23:11:25]

lgtm

[Nick Bray (chromium), 2014-08-14 01:03:51]

The CQ bit was checked by ncbray@chromium.org

[commit-bot: I haz the power, 2014-08-14 01:06:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ncbray@chromium.org/401453002/80001

[commit-bot: I haz the power, 2014-08-14 13:14:24]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)

[commit-bot: I haz the power, 2014-08-14 14:22:46]

Committed patchset #5 (80001) as 289558