Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 40143003: Simplify SharedWorkerRepository code (Closed)

Created:
7 years, 2 months ago by kinuko
Modified:
7 years, 2 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, Nils Barth (inactive), jamesr, kojih, jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive, michaeln, alecflett
Visibility:
Public.

Description

Simplify SharedWorkerRepository code - Use per-page client model rather than weird static methods - Stop using custom RuntimeFeature code - Remove dead/unnecessary code Deprecating following Blink API (multi-sided): - WebKit::WebFrameClient::createSharedWorker() - WebKit::setSharedWorkerRepository() Instead adding: - WebKit::WebView::setSharedWorkerRepositoryClient() Chromium-side patch: https://codereview.chromium.org/40303002/ BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160520

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -582 lines) Patch
M Source/bindings/v8/custom/V8WindowCustom.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/core.gypi View 2 chunks +1 line, -2 lines 0 comments Download
M Source/core/dom/Document.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/page/Page.h View 3 chunks +4 lines, -0 lines 0 comments Download
M Source/core/page/Page.cpp View 3 chunks +4 lines, -0 lines 0 comments Download
M Source/core/page/RuntimeEnabledFeatures.in View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/page/RuntimeEnabledFeaturesCustom.cpp View 1 chunk +0 lines, -43 lines 0 comments Download
D Source/core/workers/DefaultSharedWorkerRepository.h View 1 chunk +0 lines, -88 lines 0 comments Download
M Source/core/workers/SharedWorker.cpp View 4 chunks +6 lines, -3 lines 0 comments Download
D Source/core/workers/SharedWorkerRepository.h View 1 chunk +0 lines, -66 lines 0 comments Download
A + Source/core/workers/SharedWorkerRepositoryClient.h View 1 chunk +15 lines, -16 lines 0 comments Download
D Source/web/SharedWorkerRepository.cpp View 1 chunk +0 lines, -257 lines 0 comments Download
A + Source/web/SharedWorkerRepositoryClientImpl.h View 1 chunk +16 lines, -22 lines 0 comments Download
A + Source/web/SharedWorkerRepositoryClientImpl.cpp View 10 chunks +27 lines, -63 lines 0 comments Download
M Source/web/WebRuntimeFeatures.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/web/WebViewImpl.h View 3 chunks +3 lines, -0 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 3 chunks +11 lines, -0 lines 0 comments Download
M Source/web/web.gypi View 1 chunk +2 lines, -1 line 0 comments Download
M public/web/WebFrameClient.h View 1 chunk +1 line, -0 lines 0 comments Download
M public/web/WebRuntimeFeatures.h View 1 chunk +2 lines, -0 lines 0 comments Download
M public/web/WebSharedWorkerRepository.h View 1 chunk +1 line, -0 lines 0 comments Download
A + public/web/WebSharedWorkerRepositoryClient.h View 3 chunks +8 lines, -16 lines 0 comments Download
M public/web/WebView.h View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kinuko
I'd like to cleanup the SharedWorkerRepository code like this way-- can you take a look?
7 years, 2 months ago (2013-10-24 14:36:08 UTC) #1
abarth-chromium
This looks great. LGTM. Thanks!
7 years, 2 months ago (2013-10-24 14:45:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/40143003/90002
7 years, 2 months ago (2013-10-24 15:10:14 UTC) #3
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=9723
7 years, 2 months ago (2013-10-24 15:26:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/40143003/90002
7 years, 2 months ago (2013-10-25 01:26:12 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-10-25 02:34:27 UTC) #6
Message was sent while issue was closed.
Change committed as 160520

Powered by Google App Engine
This is Rietveld 408576698