Issue 401423002: clang/win: Fix calling delete[] on void* in base.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 401423002: clang/win: Fix calling delete[] on void* in base. (Closed)

Created:
6 years, 5 months ago by Nico

Modified:
6 years, 4 months ago

Reviewers:
Sigurður Ásgeirsson

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

clang/win: Fix calling delete[] on void* in base. Calling delete[] on void* is undefined behavior. Cast to the right type before calling delete[]. Fixes a clang warning. BUG=82385 TBR=siggi Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284709

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	base/win/event_trace_consumer_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/401423002/1

6 years, 5 months ago (2014-07-22 15:37:03 UTC) #4

Sigurður Ásgeirsson

6 years, 4 months ago (2014-07-28 09:30:11 UTC) #6

Message was sent while issue was closed.

lgtm - apologies for tardiness, was on vacation.