Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 401363002: [webcrypto] Add OpenSSL implementation of RSA key generation. (Closed)

Created:
6 years, 5 months ago by eroman
Modified:
6 years, 5 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

[webcrypto] Add OpenSSL implementation of RSA key generation. BUG=389317 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285607

Patch Set 1 #

Patch Set 2 : Add more comments #

Patch Set 3 : fix nss compile #

Patch Set 4 : Rebase onto dependent change #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Patch Set 7 : rebase onto master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -58 lines) Patch
M content/child/webcrypto/openssl/rsa_key_openssl.h View 1 2 3 4 1 chunk +13 lines, -0 lines 0 comments Download
M content/child/webcrypto/openssl/rsa_key_openssl.cc View 1 2 3 4 5 3 chunks +157 lines, -53 lines 0 comments Download
M content/child/webcrypto/shared_crypto_unittest.cc View 1 2 3 4 5 6 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
eroman
6 years, 5 months ago (2014-07-21 20:47:53 UTC) #1
Ryan Sleevi
There's several non-OpenSSL specific bits here. Can you split them out?
6 years, 5 months ago (2014-07-21 20:56:57 UTC) #2
eroman
Sure. I will turn this into a few dependent CLs, so the refactoring is extracted ...
6 years, 5 months ago (2014-07-21 21:03:50 UTC) #3
eroman
Done. I rebased this change on top of https://codereview.chromium.org/401233004/ so it includes just the OpenSSL ...
6 years, 5 months ago (2014-07-21 21:22:42 UTC) #4
Ryan Sleevi
lgtm
6 years, 5 months ago (2014-07-24 23:01:58 UTC) #5
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 5 months ago (2014-07-25 14:41:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/401363002/120001
6 years, 5 months ago (2014-07-25 14:42:10 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_clang_dbg on tryserver.chromium ...
6 years, 5 months ago (2014-07-25 16:51:21 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 17:12:12 UTC) #9
Message was sent while issue was closed.
Change committed as 285607

Powered by Google App Engine
This is Rietveld 408576698