Chromium Code Reviews
Help | Chromium Project | Sign in
(31)

Issue 40135: Various fixes to mouse wheel scrolling:... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 12 months ago by Peter Kasting
Modified:
5 years, 9 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Various fixes to mouse wheel scrolling: * Now that WebCore uses floating-point scroll deltas, eliminate complicated carryover code and just use simple floating-point arithmetic when calculating scroll delta. * Now that WebCore supports scrolling by page, plumb this instead of using a hacky "10 times the normal scroll amount" constant. * Don't pretend shift was down when it wasn't (e.g. WM_MOUSEHWHEEL). * Use SPI_GETWHEELSCROLLCHARS for horizontal scrolling, per MSDN. * Fix horizontal scrolling to be "scroll down to go right" as the comment said (behavior was backwards) * Clean up code. * Reorder Mac/Linux code to match Windows code ordering. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10959

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -125 lines) Patch
M webkit/glue/event_conversion.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download
M webkit/glue/webinputevent.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M webkit/glue/webinputevent_linux.cc View 1 4 chunks +7 lines, -6 lines 0 comments Download
M webkit/glue/webinputevent_mac.mm View 1 2 1 chunk +18 lines, -17 lines 1 comment Download
M webkit/glue/webinputevent_win.cc View 1 3 chunks +65 lines, -97 lines 0 comments Download
Trybot results:
Commit queue not available (can’t edit this change).

Messages

Total messages: 6 (0 generated)
Peter Kasting
Note: I'm a little worried about an int -> float change I made in the ...
7 years, 12 months ago (2009-03-04 22:41:57 UTC) #1
darin (slow to review)
LGTM on everything except webinputevent_mac.mm, which i leave to avi to review.
7 years, 12 months ago (2009-03-04 23:15:08 UTC) #2
Peter Kasting
Note: Newest version passes Mac trybot.
7 years, 12 months ago (2009-03-04 23:39:22 UTC) #3
Peter Kasting
I went ahead and submitted this on the assumption that Avi would be OK with ...
7 years, 12 months ago (2009-03-05 02:00:37 UTC) #4
Avi
It looks reasonable, so if it compiles and works as expected then fine. My problem ...
7 years, 12 months ago (2009-03-05 02:10:35 UTC) #5
rtanabe999
7 years, 12 months ago (2009-03-05 08:11:39 UTC) #6
LGTM on Windows Vista.
But, Look NO good to me on Windows XP.

static const unsigned long kDefaultScrollCharsPerWheelDelta = 1;

to

static const unsigned long kDefaultScrollCharsPerWheelDelta = 3;

IE7 look like that this value is 3 on Windows XP.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f8e48bd