Issue 4013: Port more unit tests in net/http/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4013: Port more unit tests in net/http/ (Closed)

Created:
12 years, 3 months ago by please use my chromium address

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, Dean McNamee, sgk

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Port more unit tests in net/http/ BUG=2623

Patch Set 1 #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+63 lines, -46 lines)			Patch
M	net/SConscript	View	6 chunks	+7 lines, -7 lines	0 comments	Download
M	net/base/client_socket_factory.h	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	net/base/client_socket_factory.cc	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	net/base/x509_certificate.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	net/http/http_cache.cc	View	3 chunks	+10 lines, -0 lines	0 comments	Download
M	net/http/http_cache_unittest.cc	View	5 chunks	+10 lines, -23 lines	0 comments	Download
M	net/http/http_network_layer.cc	View	2 chunks	+9 lines, -0 lines	0 comments	Download
M	net/http/http_transaction_unittest.h	View	4 chunks	+5 lines, -7 lines	0 comments	Download
M	net/http/http_transaction_unittest.cc	View	3 chunks	+1 line, -5 lines	0 comments	Download
M	net/http/http_util_unittest.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Dean McNamee

12 years, 3 months ago (2008-09-22 19:51:38 UTC) #3

Some of this is a no brainer LGTM, and I can commit tomorrow.  The parts were we
sprinkle a bunch of #ifdef linux, I'm not so sure.  It's nice to get more stuff
building, but it would almost be nicer to wait till the SSL stuff is in, so it's
not in such a ugly temporary state? :\

Expand Messages | Collapse Messages