Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 401273002: Revert of Cast: Log playout delay from receiver (Closed)

Created:
6 years, 5 months ago by dgozman
Modified:
6 years, 5 months ago
Reviewers:
miu, Alpha Left Google
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Cast: Log playout delay from receiver (https://codereview.chromium.org/401213002/) Reason for revert: This patch seems to break CastStreamingApiTestWithPixelOutput.EndToEnd. http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29/builds/32598/steps/browser_tests/logs/EndToEnd Original issue's description: > Cast: Log playout delay from receiver > > The last refactoring in RTCP handling dropped the playout delay from > receiver. This change adds it back. > > TBR=miu > BUG=393042 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284395 TBR=miu@chromium.org,hclam@chromium.org NOTREECHECKS=true NOTRY=true BUG=393042 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284411

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -34 lines) Patch
M chrome/renderer/media/cast_session_delegate.cc View 1 chunk +7 lines, -18 lines 0 comments Download
M media/cast/test/simulator.cc View 1 chunk +5 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dgozman
Created Revert of Cast: Log playout delay from receiver
6 years, 5 months ago (2014-07-21 11:29:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/401273002/1
6 years, 5 months ago (2014-07-21 11:30:27 UTC) #2
commit-bot: I haz the power
Change committed as 284411
6 years, 5 months ago (2014-07-21 11:31:34 UTC) #3
Alpha Left Google
6 years, 5 months ago (2014-07-21 18:10:34 UTC) #4
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/410443002/ by hclam@chromium.org.

The reason for reverting is: This revert wouldn't solve the flakiness. The fix
for flakiness is in CQ now. Reverting this.
.

Powered by Google App Engine
This is Rietveld 408576698