[build-fix] [gcc 4.6.*] Use iterator instead of const_iterator while using std::map::erase(...)

[build-fix] [gcc 4.6.*] Use iterator instead of const_iterator while using std::map::erase(...)

Older versions of gcc, like 4.6.* (which is the default on ubuntu 12.04 LTS), throw build error for using const_iterator.
This has been documented here [1]

[1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=57158

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284548

[vivekg, 2014-07-21 09:35:05]

Compiler Version:
================
g++ (Ubuntu/Linaro 4.6.4-6ubuntu2) 4.6.4

Build output log:
================
../../mojo/services/window_manager/window_manager_app.cc: In member function
‘void mojo::WindowManagerApp::UnregisterSubtree(mojo::view_manager::Id)’:
../../mojo/services/window_manager/window_manager_app.cc:267:34: error: no
matching function for call to ‘std::map<unsigned int,
aura::Window*>::erase(std::map<unsigned int, aura::Window*>::const_iterator&)’
../../mojo/services/window_manager/window_manager_app.cc:267:34: note:
candidates are:
/usr/include/c++/4.6/bits/stl_map.h:632:7: note: void std::map<_Key, _Tp,
_Compare, _Alloc>::erase(std::map<_Key, _Tp, _Compare, _Alloc>::iterator) [with
_Key = unsigned int, _Tp = aura::Window*, _Compare = std::less<unsigned int>,
_Alloc = std::allocator<std::pair<const unsigned int, aura::Window*> >,
std::map<_Key, _Tp, _Compare, _Alloc>::iterator =
std::_Rb_tree_iterator<std::pair<const unsigned int, aura::Window*> >]
/usr/include/c++/4.6/bits/stl_map.h:632:7: note:   no known conversion for
argument 1 from ‘std::map<unsigned int, aura::Window*>::const_iterator {aka
std::_Rb_tree_const_iterator<std::pair<const unsigned int, aura::Window*> >}’ to
‘std::_Rb_tree_iterator<std::pair<const unsigned int, aura::Window*> >’
/usr/include/c++/4.6/bits/stl_map.h:648:7: note: std::map<_Key, _Tp, _Compare,
_Alloc>::size_type std::map<_Key, _Tp, _Compare, _Alloc>::erase(const key_type&)
[with _Key = unsigned int, _Tp = aura::Window*, _Compare = std::less<unsigned
int>, _Alloc = std::allocator<std::pair<const unsigned int, aura::Window*> >,
std::map<_Key, _Tp, _Compare, _Alloc>::size_type = long unsigned int,
std::map<_Key, _Tp, _Compare, _Alloc>::key_type = unsigned int]
/usr/include/c++/4.6/bits/stl_map.h:648:7: note:   no known conversion for
argument 1 from ‘std::map<unsigned int, aura::Window*>::const_iterator {aka
std::_Rb_tree_const_iterator<std::pair<const unsigned int, aura::Window*> >}’ to
‘const key_type& {aka const unsigned int&}’
/usr/include/c++/4.6/bits/stl_map.h:682:7: note: void std::map<_Key, _Tp,
_Compare, _Alloc>::erase(std::map<_Key, _Tp, _Compare, _Alloc>::iterator,
std::map<_Key, _Tp, _Compare, _Alloc>::iterator) [with _Key = unsigned int, _Tp
= aura::Window*, _Compare = std::less<unsigned int>, _Alloc =
std::allocator<std::pair<const unsigned int, aura::Window*> >, std::map<_Key,
_Tp, _Compare, _Alloc>::iterator = std::_Rb_tree_iterator<std::pair<const
unsigned int, aura::Window*> >]
/usr/include/c++/4.6/bits/stl_map.h:682:7: note:   candidate expects 2
arguments, 1 provided

[sky, 2014-07-21 16:04:25]

LGTM

[vivekg, 2014-07-21 16:05:34]

The CQ bit was checked by vivekg@chromium.org

[commit-bot: I haz the power, 2014-07-21 16:06:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/401263002/1

[commit-bot: I haz the power, 2014-07-21 18:59:24]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-21 19:32:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-21 19:32:56]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[vivekg, 2014-07-21 22:24:57]

The CQ bit was checked by vivekg@chromium.org

[commit-bot: I haz the power, 2014-07-21 22:27:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/401263002/1

[commit-bot: I haz the power, 2014-07-22 00:16:42]

Change committed as 284548