Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 401243003: Rename CurrentMapForDeprecated to TryUpdate, and introduce Map::Update which potentially deprecates (Closed)

Created:
6 years, 5 months ago by Toon Verwaest
Modified:
6 years, 5 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Rename CurrentMapForDeprecated to TryUpdate, and introduce Map::Update which potentially deprecates BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22510

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -28 lines) Patch
M src/ast.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 chunk +7 lines, -3 lines 0 comments Download
M src/objects.cc View 6 chunks +18 lines, -23 lines 0 comments Download
M src/type-info.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 5 months ago (2014-07-21 10:39:24 UTC) #1
Igor Sheludko
lgtm
6 years, 5 months ago (2014-07-21 12:46:47 UTC) #2
Toon Verwaest
6 years, 5 months ago (2014-07-21 15:59:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22510 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698