Issue 40124: Revert r9953 since it caused regressions like:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 40124: Revert r9953 since it caused regressions like: (Closed)

Created:
11 years, 9 months ago by Ben Goodger (Google)

Modified:
9 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews_googlegroups.com, idanan

Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/src/

Visibility:
Public.

Revert r9953 since it caused regressions like: http://crbug.com/8287 Eyeballing the code in RootView, this change seems wrong. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10929

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -56 lines)			Patch
M	chrome/browser/views/tabs/tab_renderer.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/views/tabs/tab_strip.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/views/event.h	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	chrome/views/root_view.cc	View	4 chunks	+2 lines, -26 lines	0 comments	Download
M	chrome/views/view.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/views/widget_win.h	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	chrome/views/widget_win.cc	View	9 chunks	+14 lines, -19 lines	0 comments	Download
M	chrome/views/window.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 1 (0 generated)

Rubber stamp LGTM.