Refactor RSA key generation for WebCrypto's NSS implementation.

Refactor RSA key generation for WebCrypto's NSS implementation.

This refactor extracts common functionality to simplify adding the equivalent OpenSSL implementation:

 * Extracts the conversion of public exponent from a big integer to an unsigned integer
 * Restricts key sizes to multiples of 8, between 256 and 16K. This is the more restrictive range supported by NSS.

BUG=389317
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285532

[Ryan Sleevi, 2014-07-21 21:36:46]

https://codereview.chromium.org/401233004/diff/20002/content/child/webcrypto/...
File content/child/webcrypto/shared_crypto_unittest.cc (right):

https://codereview.chromium.org/401233004/diff/20002/content/child/webcrypto/...
content/child/webcrypto/shared_crypto_unittest.cc:2654: modulus_length_bits == 0
? Status::ErrorGenerateRsaZeroModulus()
Why is this a special case? Just seems like it should fall through to
unsupported.

https://codereview.chromium.org/401233004/diff/20002/content/child/webcrypto/...
File content/child/webcrypto/webcrypto_util.cc (right):

https://codereview.chromium.org/401233004/diff/20002/content/child/webcrypto/...
content/child/webcrypto/webcrypto_util.cc:34: if (reverse_i >= sizeof(unsigned
int) && data[i])
sizeof(*result)

https://codereview.chromium.org/401233004/diff/20002/content/child/webcrypto/...
File content/child/webcrypto/webcrypto_util.h (right):

https://codereview.chromium.org/401233004/diff/20002/content/child/webcrypto/...
content/child/webcrypto/webcrypto_util.h:103: Status GetRsaKeyGenGetParameters(
Why the extra (Get) in here?

Shouldn't this be GetRsaKeyGenParameters() ?

[eroman, 2014-07-21 21:52:21]

https://codereview.chromium.org/401233004/diff/20002/content/child/webcrypto/...
File content/child/webcrypto/shared_crypto_unittest.cc (right):

https://codereview.chromium.org/401233004/diff/20002/content/child/webcrypto/...
content/child/webcrypto/shared_crypto_unittest.cc:2654: modulus_length_bits == 0
? Status::ErrorGenerateRsaZeroModulus()
On 2014/07/21 21:36:45, Ryan Sleevi wrote:
> Why is this a special case? Just seems like it should fall through to
> unsupported.

Done.

Indeed, not sure why this was a separate error

https://codereview.chromium.org/401233004/diff/20002/content/child/webcrypto/...
File content/child/webcrypto/webcrypto_util.cc (right):

https://codereview.chromium.org/401233004/diff/20002/content/child/webcrypto/...
content/child/webcrypto/webcrypto_util.cc:34: if (reverse_i >= sizeof(unsigned
int) && data[i])
On 2014/07/21 21:36:45, Ryan Sleevi wrote:
> sizeof(*result)

Done.

https://codereview.chromium.org/401233004/diff/20002/content/child/webcrypto/...
File content/child/webcrypto/webcrypto_util.h (right):

https://codereview.chromium.org/401233004/diff/20002/content/child/webcrypto/...
content/child/webcrypto/webcrypto_util.h:103: Status GetRsaKeyGenGetParameters(
On 2014/07/21 21:36:46, Ryan Sleevi wrote:
> Why the extra (Get) in here?
> 
> Shouldn't this be GetRsaKeyGenParameters() ?

Done.

(Typo on my part, that was then propagated via code completion.)

[Ryan Sleevi, 2014-07-24 23:03:43]

lgtm

https://codereview.chromium.org/401233004/diff/150001/content/child/webcrypto...
File content/child/webcrypto/webcrypto_util.cc (right):

https://codereview.chromium.org/401233004/diff/150001/content/child/webcrypto...
content/child/webcrypto/webcrypto_util.cc:35: return false;  // Too large for a
long.
Comment out of date.

[eroman, 2014-07-24 23:36:48]

https://codereview.chromium.org/401233004/diff/150001/content/child/webcrypto...
File content/child/webcrypto/webcrypto_util.cc (right):

https://codereview.chromium.org/401233004/diff/150001/content/child/webcrypto...
content/child/webcrypto/webcrypto_util.cc:35: return false;  // Too large for a
long.
On 2014/07/24 23:03:43, Ryan Sleevi wrote:
> Comment out of date.

Done.

[eroman, 2014-07-24 23:36:55]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2014-07-24 23:38:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eroman@chromium.org/401233004/170001

[eroman, 2014-07-25 05:06:06]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2014-07-25 05:07:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eroman@chromium.org/401233004/190001

[commit-bot: I haz the power, 2014-07-25 08:38:06]

Change committed as 285532