Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 401233003: Migrate all usages of xxd.py to blink_resources.grd and remove xxd.py - Part 1 (Closed)

Created:
6 years, 5 months ago by vivekg_samsung
Modified:
6 years, 5 months ago
CC:
abarth-chromium, blink-reviews, dglazkov+blink, jamesr
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Migrate all usages of xxd.py to blink_resources.grd and remove xxd.py - Part 1 Blink should make use of blink_resources.grd for the inline resources of inspector. This removes the dependency upon using xxd.py which embeds these resources as strings. Part 2: https://crrev.com/403273003 Part 3: https://crrev.com/402033002 BUG=312586 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178832

Patch Set 1 #

Total comments: 1

Patch Set 2 : Patch for landing! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M public/blink_resources.grd View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
vivekg
PTAL, thank you!
6 years, 5 months ago (2014-07-21 09:23:06 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-21 11:28:38 UTC) #2
vivekg
The CQ bit was checked by vivekg@chromium.org
6 years, 5 months ago (2014-07-21 11:29:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/401233003/1
6 years, 5 months ago (2014-07-21 11:30:17 UTC) #4
vivekg
The CQ bit was unchecked by vivekg@chromium.org
6 years, 5 months ago (2014-07-21 11:59:13 UTC) #5
vivekg
I think for inspector related changes, we could modify WebKit/Source/devtools/scripts/generate_devtools_grd.py instead of blink_resources.grd. Will update ...
6 years, 5 months ago (2014-07-21 11:59:52 UTC) #6
vivekg
On 2014/07/21 11:59:52, vivekg_ wrote: > I think for inspector related changes, we could modify ...
6 years, 5 months ago (2014-07-21 14:59:46 UTC) #7
vivekg
Friendly ping!
6 years, 5 months ago (2014-07-22 11:16:37 UTC) #8
jochen (gone - plz use gerrit)
On 2014/07/22 at 11:16:37, vivekg wrote: > Friendly ping! I defer to Pavel on this ...
6 years, 5 months ago (2014-07-22 11:27:07 UTC) #9
vivekg
On 2014/07/22 11:27:07, jochen wrote: > On 2014/07/22 at 11:16:37, vivekg wrote: > > Friendly ...
6 years, 5 months ago (2014-07-24 07:28:39 UTC) #10
pfeldman
lgtm https://codereview.chromium.org/401233003/diff/1/public/blink_resources.grd File public/blink_resources.grd (right): https://codereview.chromium.org/401233003/diff/1/public/blink_resources.grd#newcode15 public/blink_resources.grd:15: <include name="IDR_INJECTED_SCRIPT_CANVAS_MODULE_SOURCE" file="../Source/core/inspector/InjectedScriptCanvasModuleSource.js" type="BINDATA"/> Lets prefix all consts ...
6 years, 5 months ago (2014-07-24 07:50:43 UTC) #11
vivekg
On 2014/07/24 07:50:43, pfeldman wrote: > lgtm > > https://codereview.chromium.org/401233003/diff/1/public/blink_resources.grd > File public/blink_resources.grd (right): > ...
6 years, 5 months ago (2014-07-24 09:49:18 UTC) #12
vivekg
The CQ bit was checked by vivekg@chromium.org
6 years, 5 months ago (2014-07-24 09:49:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/401233003/20001
6 years, 5 months ago (2014-07-24 09:50:23 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_gpu_retina_triggered_tests on tryserver.chromium.gpu ...
6 years, 5 months ago (2014-07-24 10:56:45 UTC) #15
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 11:22:04 UTC) #16
Message was sent while issue was closed.
Change committed as 178832

Powered by Google App Engine
This is Rietveld 408576698