Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 401213002: Cast: Log playout delay from receiver (Closed)

Created:
6 years, 5 months ago by Alpha Left Google
Modified:
6 years, 5 months ago
Reviewers:
miu
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Cast: Log playout delay from receiver The last refactoring in RTCP handling dropped the playout delay from receiver. This change adds it back. TBR=miu BUG=393042 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284395

Patch Set 1 #

Patch Set 2 : namespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -10 lines) Patch
M chrome/renderer/media/cast_session_delegate.cc View 1 1 chunk +16 lines, -5 lines 0 comments Download
M media/cast/test/simulator.cc View 1 chunk +16 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Alpha Left Google
6 years, 5 months ago (2014-07-20 22:34:30 UTC) #1
Alpha Left Google
The CQ bit was checked by hclam@chromium.org
6 years, 5 months ago (2014-07-20 22:34:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/401213002/1
6 years, 5 months ago (2014-07-20 22:34:47 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium ...
6 years, 5 months ago (2014-07-21 01:17:42 UTC) #4
Alpha Left Google
The CQ bit was checked by hclam@chromium.org
6 years, 5 months ago (2014-07-21 01:21:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/401213002/20001
6 years, 5 months ago (2014-07-21 01:21:28 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-21 03:09:28 UTC) #7
commit-bot: I haz the power
Change committed as 284395
6 years, 5 months ago (2014-07-21 07:10:25 UTC) #8
dgozman
6 years, 5 months ago (2014-07-21 11:29:12 UTC) #9
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/401273002/ by dgozman@chromium.org.

The reason for reverting is: This patch seems to break
CastStreamingApiTestWithPixelOutput.EndToEnd.

http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29....

Powered by Google App Engine
This is Rietveld 408576698