Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1553)

Unified Diff: Tools/GardeningServer/ui/ct-results-detail.html

Issue 401163002: Fix exceptions when running the tests. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rename function Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Tools/GardeningServer/ui/ct-results-by-builder-tests.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/GardeningServer/ui/ct-results-detail.html
diff --git a/Tools/GardeningServer/ui/ct-results-detail.html b/Tools/GardeningServer/ui/ct-results-detail.html
index c706f5a2337ce370aa083a5d933d1bd46770228f..70c40f2208aef333ad7635f242cbfc964ea0fe32 100644
--- a/Tools/GardeningServer/ui/ct-results-detail.html
+++ b/Tools/GardeningServer/ui/ct-results-detail.html
@@ -54,6 +54,8 @@ found in the LICENSE file.
return;
var failureInfo = results.failureInfo(this.test, this.builder, this.result);
+ // FIXME: Move this logic to a proper model class so that the network requests this makes
+ // can be easily mocked out in tests.
results.fetchResultsURLs(failureInfo).then(function(resultsUrls) {
var resultsUrlsByTypeAndKind = {};
resultsUrls.forEach(function(url) {
« no previous file with comments | « Tools/GardeningServer/ui/ct-results-by-builder-tests.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698