Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2785)

Unified Diff: Tools/GardeningServer/ui/ct-results-by-builder-tests.html

Issue 401163002: Fix exceptions when running the tests. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/ui/ct-results-by-builder-tests.html
diff --git a/Tools/GardeningServer/ui/ct-results-by-builder-tests.html b/Tools/GardeningServer/ui/ct-results-by-builder-tests.html
index 2ba8df248e9d958f353846d88804ef88c03f48a6..e10463a80f1a95664cd4b40037761e9dccd0fdcd 100644
--- a/Tools/GardeningServer/ui/ct-results-by-builder-tests.html
+++ b/Tools/GardeningServer/ui/ct-results-by-builder-tests.html
@@ -35,26 +35,32 @@ var kExampleFailure = {
module("ct-results-by-builder");
asyncTest("basic", 11, function() {
- var results = document.createElement('ct-results-by-builder');
+ // FIXME: Remove this override when ct-results-detail is fixed to not use
+ // results.fetchResultsURLs.
+ var oldFetchResultsURLs = results.fetchResultsURLs;
+ results.fetchResultsURLs = function() { return Promise.resolve([]); };
- results.failure = kExampleFailure;
+ var resultsByBuilder = document.createElement('ct-results-by-builder');
+ resultsByBuilder.failure = kExampleFailure;
- Platform.endOfMicrotask(function() {
- var tabs = results.shadowRoot.querySelectorAll('paper-tab');
+ requestAnimationFrame(function() {
+ var tabs = resultsByBuilder.shadowRoot.querySelectorAll('paper-tab');
equal(tabs.length, 2);
equal(tabs[0].textContent, 'Linux (dbg)');
equal(tabs[1].textContent, 'Mac10.6 (dbg)');
- var detail = results.shadowRoot.querySelectorAll('ct-results-detail');
+ var detail = resultsByBuilder.shadowRoot.querySelectorAll('ct-results-detail');
equal(detail.length, 1);
equal(detail[0].test, 'inspector/console/console-viewport-selection.html');
equal(detail[0].builder, 'WebKit Linux (dbg)');
equal(detail[0].result, 'TEXT');
- results.shadowRoot.querySelector('paper-tabs').selected = 1;
+ resultsByBuilder.shadowRoot.querySelector('paper-tabs').selected = 1;
- Platform.endOfMicrotask(function() {
- var detail = results.shadowRoot.querySelectorAll('ct-results-detail');
+ requestAnimationFrame(function() {
+ results.fetchResultsURLs = oldFetchResultsURLs;
+
+ var detail = resultsByBuilder.shadowRoot.querySelectorAll('ct-results-detail');
equal(detail.length, 1);
equal(detail[0].test, 'inspector/console/console-viewport-selection.html');
equal(detail[0].builder, 'WebKit Mac10.6 (dbg)');

Powered by Google App Engine
This is Rietveld 408576698