Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(916)

Issue 40113002: Tune cctest/test-parsing/ParserSync. (Closed)

Created:
7 years, 2 months ago by Sven Panne
Modified:
7 years, 2 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Tune cctest/test-parsing/ParserSync. This test suffers heavily from combinatorial explosion. To redemedy this situation a bit, two independent parsing flags are tested separately, reducing the runtime by a factor of 4. Furthermore, the code has been cleaned up a bit. R=mstarzinger@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=17385

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -29 lines) Patch
M test/cctest/test-parsing.cc View 1 6 chunks +41 lines, -29 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Michael Starzinger
LGTM with one comment to address. https://codereview.chromium.org/40113002/diff/1/test/cctest/test-parsing.cc File test/cctest/test-parsing.cc (right): https://codereview.chromium.org/40113002/diff/1/test/cctest/test-parsing.cc#newcode1093 test/cctest/test-parsing.cc:1093: void SetParserFlags(T* parser, ...
7 years, 2 months ago (2013-10-24 17:00:34 UTC) #1
Sven Panne
7 years, 2 months ago (2013-10-25 07:24:14 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 manually as r17385 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698