Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 401113002: Add extensions_unittests target to main waterfall. (Closed)

Created:
6 years, 5 months ago by tfarina
Modified:
6 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, Yoyo Zhou, James Cook
Project:
chromium
Visibility:
Public.

Description

Add extensions_unittests target to main waterfall. This puts extensions_unittests target in the major platforms (Windows, MacOSX and Linux) and by adding it to the main waterfall it means it becomes a tree blocker, if you break it you either have to fix it promptly or revert right way. BUG=348066 TEST=trybots+cq+waterfall R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284837

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M testing/buildbot/chromium.linux.json View 1 chunk +1 line, -0 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 1 chunk +1 line, -0 lines 0 comments Download
M testing/buildbot/chromium.win.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tfarina
James, do you need this for this weekend? Scott usually do not do reviews on ...
6 years, 5 months ago (2014-07-19 01:05:50 UTC) #1
James Cook
On 2014/07/19 01:05:50, tfarina wrote: > James, do you need this for this weekend? Scott ...
6 years, 5 months ago (2014-07-21 17:16:21 UTC) #2
tfarina
Scott, ping??
6 years, 5 months ago (2014-07-22 16:27:56 UTC) #3
sky
Did these run on the FYI bot for a while to make sure they aren't ...
6 years, 5 months ago (2014-07-22 18:03:39 UTC) #4
tfarina
On Tue, Jul 22, 2014 at 3:03 PM, <sky@chromium.org> wrote: > Did these run on ...
6 years, 5 months ago (2014-07-22 18:09:03 UTC) #5
sky
Perfect. LGTM then
6 years, 5 months ago (2014-07-22 18:29:04 UTC) #6
tfarina
6 years, 5 months ago (2014-07-23 02:12:15 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r284837 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698