Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 401103006: Remove debugging code from gypv8sh.py (Closed)

Created:
6 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 5 months ago
Reviewers:
Nico
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Remove debugging code from gypv8sh.py Since upgrading the builder to 10.8, it never failed again. BUG=370551 R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284668

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -35 lines) Patch
M tools/gypv8sh.py View 1 chunk +0 lines, -35 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
jochen (gone - plz use gerrit)
6 years, 5 months ago (2014-07-21 06:52:13 UTC) #1
Nico
lgtm So I guess there's some 10.6-only bug? :-/
6 years, 5 months ago (2014-07-21 18:11:57 UTC) #2
jochen (gone - plz use gerrit)
On 2014/07/21 at 18:11:57, thakis wrote: > lgtm > > So I guess there's some ...
6 years, 5 months ago (2014-07-22 08:30:29 UTC) #3
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 5 months ago (2014-07-22 08:30:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/401103006/1
6 years, 5 months ago (2014-07-22 08:31:40 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-22 10:18:58 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 11:08:45 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/41494)
6 years, 5 months ago (2014-07-22 11:08:46 UTC) #8
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 5 months ago (2014-07-22 12:03:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/401103006/1
6 years, 5 months ago (2014-07-22 12:04:01 UTC) #10
jochen (gone - plz use gerrit)
Committed patchset #1 manually as r284668 (presubmit successful).
6 years, 5 months ago (2014-07-22 12:17:41 UTC) #11
Nico
6 years, 5 months ago (2014-07-22 13:49:19 UTC) #12 
No, that one doesn't happen on 10.6, only on newer systems.
On Jul 22, 2014 1:30 AM, <jochen@chromium.org> wrote:

> On 2014/07/21 at 18:11:57, thakis wrote:
>
>> lgtm
>>
>
>  So I guess there's some 10.6-only bug? :-/
>>
>
> maybe crbug.com/313077 ?
>
> https://codereview.chromium.org/401103006/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698