Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 401103004: Revert of Use language-specific street address line separators (Closed)

Created:
6 years, 5 months ago by please use gerrit instead
Modified:
6 years, 5 months ago
Reviewers:
aruslan, Evan Stade
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Use language-specific street address line separators (https://codereview.chromium.org/397233002/) Reason for revert: Broke 'Chromium Linux on Linux Clang (dbg)': http://build.chromium.org/p/chromium.linux/builders/Linux%20Clang%20%28dbg%29/builds/62289 AutofillDialogControllerTest.BillingVsShippingStreetAddress (run #1): [ RUN ] AutofillDialogControllerTest.BillingVsShippingStreetAddress Xlib: extension "RANDR" missing on display ":9". /usr/lib/gcc/x86_64-linux-gnu/4.6/../../../../include/c++/4.6/debug/safe_iterator.h:289: error: attempt to advance a past-the-end iterator 1 steps, which falls outside its valid range. Objects involved in the operation: iterator @ 0x0x7fffd4a50d58 { state = past-the-end; references sequence @ 0x0x7fffd4a50d58 } Received signal 6 #0 0x7f716d77ecee base::debug::StackTrace::StackTrace() #1 0x7f716d77e827 base::debug::(anonymous namespace)::StackDumpSignalHandler() #2 0x7f7168451cb0 \u003Cunknown> #3 0x7f71648cf425 gsignal #4 0x7f71648d2b8b abort #5 0x7f7164ed25ad __gnu_debug::_Error_formatter::_M_error() #6 0x0000026271ce __gnu_debug::_Safe_iterator\u003C>::operator+=() #7 0x0000026270f5 __gnu_debug::_Safe_iterator\u003C>::operator+() #8 0x000005506f39 i18n::addressinput::(anonymous namespace)::CombineLinesForLanguage() #9 0x00000550703a i18n::addressinput::GetStreetAddressLinesAsSingleLine() #10 0x000005548289 autofill::(anonymous namespace)::FillStreetAddress() #11 0x000005547b91 autofill::AutofillField::FillFormField() #12 0x0000055907cd autofill::FormStructure::FillFields() #13 0x000004972335 autofill::AutofillDialogControllerImpl::Show() #14 0x000001ec0f2a autofill::(anonymous namespace)::AutofillDialogControllerTest::SetUpControllerWithFormData() #15 0x000001ece5c8 autofill::AutofillDialogControllerTest_BillingVsShippingStreetAddress_Test::TestBody() #16 0x0000039fcc63 testing::internal::HandleSehExceptionsInMethodIfSupported\u003C>() #17 0x0000039e9f9e testing::internal::HandleExceptionsInMethodIfSupported\u003C>() #18 0x0000039e0e05 testing::Test::Run() #19 0x0000039e151b testing::TestInfo::Run() #20 0x0000039e1b0a testing::TestCase::Run() #21 0x0000039e6118 testing::internal::UnitTestImpl::RunAllTests() #22 0x0000039f5973 testing::internal::HandleSehExceptionsInMethodIfSupported\u003C>() #23 0x0000039ebb0e testing::internal::HandleExceptionsInMethodIfSupported\u003C>() #24 0x0000039e5da4 testing::UnitTest::Run() #25 0x000005b72b61 RUN_ALL_TESTS() #26 0x000005b71be7 base::TestSuite::Run() #27 0x000005b8455d content::UnitTestTestSuite::Run() #28 0x000003aa40d2 base::internal::RunnableAdapter\u003C>::Run() #29 0x000003aa403c base::internal::InvokeHelper\u003C>::MakeItSo() #30 0x000003aa3fea base::internal::Invoker\u003C>::Run() #31 0x000002a29e9e base::Callback\u003C>::Run() #32 0x000005b6b830 base::(anonymous namespace)::LaunchUnitTestsInternal() #33 0x000005b6b527 base::LaunchUnitTests() #34 0x000003aa3db5 main #35 0x7f71648ba76d __libc_start_main #36 0x000000715159 \u003Cunknown> r8: 00007f715f665980 r9: 00007fffd4a507d8 r10: 0000000000000008 r11: 0000000000000206 r12: 00007fffd4a50aa0 r13: 0000000000000001 r14: 0000000000000001 r15: 0000000000000000 di: 00000000000016b2 si: 00000000000016b2 bp: 0000000000000002 bx: 00007fffd4a50a30 dx: 0000000000000006 ax: 0000000000000000 cx: ffffffffffffffff sp: 00007fffd4a50828 ip: 00007f71648cf425 efl: 0000000000000206 cgf: 0000000000000033 erf: 0000000000000000 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000 Original issue's description: > Use language-specific street address line separators > > Fill street address into a single-line text input field with separators > that depend on the language code of the profile. > > TEST=components_unittests:AutofillFieldTest.FillStreetAddress* > BUG=270261 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284335 TBR=estade@chromium.org,aruslan@chromium.org NOTREECHECKS=true NOTRY=true BUG=270261 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284340

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -126 lines) Patch
M chrome/browser/ui/android/autofill/autofill_dialog_controller_android.cc View 2 chunks +4 lines, -9 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/autofill/data_model_wrapper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/core/browser/autofill_field.h View 1 chunk +3 lines, -5 lines 0 comments Download
M components/autofill/core/browser/autofill_field.cc View 4 chunks +5 lines, -15 lines 0 comments Download
M components/autofill/core/browser/autofill_field_unittest.cc View 24 chunks +45 lines, -77 lines 0 comments Download
M components/autofill/core/browser/autofill_manager.cc View 3 chunks +4 lines, -13 lines 0 comments Download
M components/autofill/core/browser/form_structure.h View 1 chunk +1 line, -3 lines 0 comments Download
M components/autofill/core/browser/form_structure.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
please use gerrit instead
Created Revert of Use language-specific street address line separators
6 years, 5 months ago (2014-07-19 18:42:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/401103004/1
6 years, 5 months ago (2014-07-19 18:43:30 UTC) #2
commit-bot: I haz the power
Change committed as 284340
6 years, 5 months ago (2014-07-19 18:43:48 UTC) #3
please use gerrit instead
6 years, 5 months ago (2014-07-19 20:11:15 UTC) #4
Message was sent while issue was closed.
Relanding in https://codereview.chromium.org/403923003/.

Powered by Google App Engine
This is Rietveld 408576698