Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1268)

Issue 401073002: Repair WebRtcBrowserTest names in drmemory exclusions file (Closed)

Created:
6 years, 5 months ago by ncarter (slow)
Modified:
6 years, 5 months ago
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org, groby-ooo-7-16
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Repair WebRtcBrowserTest names in drmemory exclusions file (these tests changed names when they went from TEST_P to TEST_F in r283700). Fix spelling error in three test names. Eliminate memory error suppressions that were put in as fixes: * Revert "[MemSheriff] Suppress unreadable mem access" * This reverts commit a922608663a6fd861aeff6fd2bc3984dcbda86db. * (aka svn r283943) * Revert "[MemSheriff] Disable failing tests" * This reverts commit 565a8552b8e194807358b33ff741ae55ac9da901. * (aka svn r284133) BUG=394957, 395172, 389132, 389098 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284308

Patch Set 1 #

Patch Set 2 : Fix names in tests #

Patch Set 3 : Actually fix exclusions file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -38 lines) Patch
M content/browser/media/webrtc_browsertest.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download
M tools/valgrind/drmemory/suppressions.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D tools/valgrind/gtest_exclude/content_browsertests.gtest-drmemory.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/valgrind/gtest_exclude/content_browsertests.gtest-drmemory_win32.txt View 1 2 2 chunks +16 lines, -17 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
ncarter (slow)
vrk -- please review
6 years, 5 months ago (2014-07-18 22:26:25 UTC) #1
ncarter (slow)
+groby fyi
6 years, 5 months ago (2014-07-18 22:29:18 UTC) #2
vrk (LEFT CHROMIUM)
lgtm media
6 years, 5 months ago (2014-07-18 22:30:03 UTC) #3
ncarter (slow)
The CQ bit was checked by nick@chromium.org
6 years, 5 months ago (2014-07-18 22:33:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nick@chromium.org/401073002/40001
6 years, 5 months ago (2014-07-18 22:37:52 UTC) #5
groby-ooo-7-16
LGTM
6 years, 5 months ago (2014-07-18 22:55:11 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-19 02:08:02 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-19 04:43:17 UTC) #8
Message was sent while issue was closed.
Change committed as 284308

Powered by Google App Engine
This is Rietveld 408576698