Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 401053002: Don't set accelerated compositing to true in WebView. It's already defaulted to true. (Closed)

Created:
6 years, 5 months ago by chrishtr
Modified:
6 years, 5 months ago
Reviewers:
jamesr
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Don't set accelerated compositing to true in WebView. It's already defaulted to true. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284634

Patch Set 1 #

Patch Set 2 : Merged. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M content/renderer/render_view_impl.cc View 1 1 chunk +0 lines, -3 lines 1 comment Download

Messages

Total messages: 10 (0 generated)
chrishtr
This CL will allow me to make some other changes to WebViewImpl in cases when ...
6 years, 5 months ago (2014-07-18 23:21:13 UTC) #1
jamesr
lgtm https://codereview.chromium.org/401053002/diff/20001/content/renderer/render_view_impl.cc File content/renderer/render_view_impl.cc (left): https://codereview.chromium.org/401053002/diff/20001/content/renderer/render_view_impl.cc#oldcode1049 content/renderer/render_view_impl.cc:1049: settings->setAcceleratedCompositingEnabled(true); for the record, https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/core/frame/Settings.in&q=acceleratedCompositingEnabled&sq=package:chromium&type=cs&l=71 sets this to ...
6 years, 5 months ago (2014-07-22 01:05:05 UTC) #2
chrishtr
The CQ bit was checked by chrishtr@chromium.org
6 years, 5 months ago (2014-07-22 01:50:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/401053002/20001
6 years, 5 months ago (2014-07-22 01:51:52 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-22 03:03:57 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 04:15:16 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/173313)
6 years, 5 months ago (2014-07-22 04:15:16 UTC) #7
chrishtr
The CQ bit was checked by chrishtr@chromium.org
6 years, 5 months ago (2014-07-22 04:53:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/401053002/20001
6 years, 5 months ago (2014-07-22 04:54:11 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 06:06:35 UTC) #10
Message was sent while issue was closed.
Change committed as 284634

Powered by Google App Engine
This is Rietveld 408576698