Issue 40103: Fix issue 246.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 40103: Fix issue 246. (Closed)

Created:
11 years, 9 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Christian Plesner Hansen

CC:
v8-dev

Visibility:
Public.

Description

Issue 246 - wait until regexp is parsed to detect whether it's simple.

Patch Set 1 #

Total comments: 2

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -3 lines)			Patch
	M	src/parser.cc	View		4 chunks	+6 lines, -3 lines	0 comments	Download
	A	test/mjsunit/regress/regress-246.js	View		1 chunk	+31 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Christian Plesner Hansen

Lgtm! http://codereview.chromium.org/40103/diff/1/3 File test/mjsunit/regress/regress-246.js (right): http://codereview.chromium.org/40103/diff/1/3#newcode28 Line 28: // See: http://code.google.com/p/v8/issues/detail?id=246 This is sort of ...

11 years, 9 months ago (2009-03-04 09:42:50 UTC) #2

Lasse Reichstein

11 years, 9 months ago (2009-03-04 09:51:07 UTC) #3

http://codereview.chromium.org/40103/diff/1/3
File test/mjsunit/regress/regress-246.js (right):

http://codereview.chromium.org/40103/diff/1/3#newcode28
Line 28: // See: http://code.google.com/p/v8/issues/detail?id=246
Yes, it's merely a service to provide a direct link to the issue.

Expand Messages | Collapse Messages