Issue 401025: Remove shortcut key Ctrl+Alt+B (IDC_SHOW_EXTENSION_SHELF)....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 401025: Remove shortcut key Ctrl+Alt+B (IDC_SHOW_EXTENSION_SHELF).... (Closed)

Created:
11 years, 1 month ago by James Su

Modified:
9 years, 7 months ago

Reviewers:
Aaron Boodman, Finnur

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Remove shortcut key Ctrl+Alt+B (IDC_SHOW_EXTENSION_SHELF). On Windows, Ctrl+Alt+B equals to AltGR+B, which corresponds to '{' on Hungarian keyboard. BUG=27137 TEST=Switch to Hungarian keyboard layout, then try to input '{' in both omnibox and web content area by pressing AltGR+B.

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	chrome/app/chrome_dll.rc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Finnur

I am OK with this. Aaron, you think we need to retain this functionality behind ...

11 years, 1 month ago (2009-11-18 07:00:28 UTC) #2

Aaron Boodman

I'm fine with removing it completely from a product standpoint. Finnur, can you comment on ...

11 years, 1 month ago (2009-11-18 23:40:19 UTC) #3

Finnur

11 years, 1 month ago (2009-11-18 23:46:37 UTC) #4

Yeah, this is the file I modified to add it. LGTM.

On 2009/11/18 23:40:19, Aaron Boodman wrote:
> I'm fine with removing it completely from a product standpoint.
> 
> Finnur, can you comment on whether this is the right place to make this
change?
> I always get confused as to which resource files are generated and not
supposed
> to be modified.

Expand Messages | Collapse Messages