Issue 401014: Merge 32115 - Mac: Draw entire Bookmark Bar every time to match API expectati...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 401014: Merge 32115 - Mac: Draw entire Bookmark Bar every time to match API expectati... (Closed)

Created:
11 years, 1 month ago by Elliot Glaysher

Modified:
9 years, 7 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/249/src/

Visibility:
Public.

Description

Merge 32115 - Mac: Draw entire Bookmark Bar every time to match API expectations. NtpBackgroundUtil::PaintBackgroundDetachedMode() expects to draw the entire bookmark bar on every expose; all of its internal math is based on the assumption that the incoming area is zerobased and is the whole bookmark bar area. TEST=(Repo instructions in bug) BUG=25655 Review URL: http://codereview.chromium.org/401005 TBR=erg@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32226

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -2 lines)			Patch
	M	chrome/browser/cocoa/bookmark_bar_toolbar_view.mm	View		1 chunk	+12 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages