Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 401013003: Oilpan: tidy up transition type usage after r178508. (Closed)

Created:
6 years, 5 months ago by sof
Modified:
6 years, 5 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, groby+blinkspell_chromium.org, hj.r.chung, Ken Russell (switch to Gerrit)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Oilpan: tidy up transition type usage after r178508. The Image object is not on the heap, adjust transition type usage to reflect that. Not doing so lead to virtual/threaded/compositing/webgl/webgl-copy-image.html failing in Oilpan builds -- http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=virtual%2Fthreaded%2Fcompositing%2Fwebgl%2Fwebgl-copy-image.html TBR=haraken@chromium.org,oilpan-reviews@chromium.org BUG=392765 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178514

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/editing/Editor.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
sof
Please take a look.
6 years, 5 months ago (2014-07-19 06:58:57 UTC) #1
sof
The use of "regressing" in the description was wrong (it is a new test that ...
6 years, 5 months ago (2014-07-19 07:02:51 UTC) #2
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 5 months ago (2014-07-19 07:09:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/401013003/1
6 years, 5 months ago (2014-07-19 07:09:25 UTC) #4
commit-bot: I haz the power
Change committed as 178514
6 years, 5 months ago (2014-07-19 07:09:47 UTC) #5
haraken
6 years, 5 months ago (2014-07-19 07:34:45 UTC) #6
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698