Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 401013002: DevTools: Freshen up popover styles. (Closed)

Created:
6 years, 5 months ago by pfeldman
Modified:
6 years, 5 months ago
Reviewers:
vsevik, sergeyv
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Freshen up popover styles. Drop the aging yellow popover and match the tooltip style in Chrome. TBR=sergeyv BUG=181703 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178466

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -67 lines) Patch
M Source/devtools/devtools.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/devtools/front_end/Images/popoverArrows.png View Binary file 0 comments Download
M Source/devtools/front_end/Images/popoverBackground.png View Binary file 0 comments Download
D Source/devtools/front_end/Images/trackHoriz.png View Binary file 0 comments Download
D Source/devtools/front_end/Images/trackVert.png View Binary file 0 comments Download
M Source/devtools/front_end/dialog.css View 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/elements/Spectrum.js View 2 chunks +3 lines, -7 lines 0 comments Download
M Source/devtools/front_end/inspectorStyle.css View 2 chunks +5 lines, -20 lines 0 comments Download
M Source/devtools/front_end/popover.css View 7 chunks +8 lines, -8 lines 0 comments Download
M Source/devtools/front_end/spectrum.css View 4 chunks +26 lines, -29 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
pfeldman
6 years, 5 months ago (2014-07-18 15:39:09 UTC) #1
pfeldman
The CQ bit was checked by pfeldman@chromium.org
6 years, 5 months ago (2014-07-18 15:48:15 UTC) #2
pfeldman
6 years, 5 months ago (2014-07-18 15:48:25 UTC) #3
vsevik
The CQ bit was unchecked by vsevik@chromium.org
6 years, 5 months ago (2014-07-18 15:48:27 UTC) #4
pfeldman
The CQ bit was checked by pfeldman@chromium.org
6 years, 5 months ago (2014-07-18 15:48:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/401013002/1
6 years, 5 months ago (2014-07-18 15:49:59 UTC) #6
vsevik
The CQ bit was unchecked by vsevik@chromium.org
6 years, 5 months ago (2014-07-18 15:51:06 UTC) #7
vsevik
The CQ bit was checked by vsevik@chromium.org
6 years, 5 months ago (2014-07-18 15:53:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/401013002/1
6 years, 5 months ago (2014-07-18 15:54:06 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-18 17:15:10 UTC) #10
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 17:43:47 UTC) #11
Message was sent while issue was closed. 
Change committed as 178466

Powered by Google App Engine
This is Rietveld 408576698