Issue 401009: Add browser tests for the BLOCK_THIRD_PARTY_COOKIES...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 401009: Add browser tests for the BLOCK_THIRD_PARTY_COOKIES... (Closed)

Created:
11 years, 1 month ago by wtc

Modified:
9 years, 7 months ago

Reviewers:
eroman, abarth-chromium

CC:
chromium-reviews_googlegroups.com, darin (slow to review), ben+cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add browser tests for the BLOCK_THIRD_PARTY_COOKIES policy to verify we allow first-party cookies in the regular and redirected cases. R=abarth,eroman BUG=25133 TEST=new browser tests are added Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32257

Patch Set 1 #

Patch Set 2 : Try tp fix compilation errors on Linux and Mac. Rename tests. #

Total comments: 1

Patch Set 3 : Upload before checkin #

Patch Set 4 : Upload before checkin #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -0 lines)			Patch
	A	chrome/browser/net/cookie_policy_browsertest.cc	View	1 2	1 chunk	+87 lines, -0 lines	0 comments	Download
	M	chrome/chrome.gyp	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

wtc

After several hours of laboring, here are the browser tests for the "block third-party cookies" ...

11 years, 1 month ago (2009-11-17 03:23:59 UTC) #1

abarth-chromium

Thanks Wan-Teh. These tests will be very useful to us. It looks like you're having ...

11 years, 1 month ago (2009-11-17 03:48:23 UTC) #2

wtc

Please review Patch Set 2. I tried to fix the compilation errors on Linux and ...

11 years, 1 month ago (2009-11-17 18:44:48 UTC) #3

eroman

11 years, 1 month ago (2009-11-17 22:06:25 UTC) #4

LGTM, thanks!

http://codereview.chromium.org/401009/diff/4/1004
File chrome/browser/net/cookie_policy_browsertest.cc (right):

http://codereview.chromium.org/401009/diff/4/1004#newcode48
Line 48: // Visit a page that is a redirect to a page that sets a cookie.
nit: for consistency with above, how about "Visits".

Also, can you mention that the redirect crosses domain boundary?

Expand Messages | Collapse Messages