Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 400993003: Save slider preferences when using touch. (Closed)

Created:
6 years, 5 months ago by michaelpg
Modified:
6 years, 5 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Save slider preferences when using touch. On the Settings page, when you change a slider (input type="range") by touch, we don't save the associated preference. Listen to touchend and touchcancel, and add a test for this. BUG=394938 R=estade@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284292

Patch Set 1 #

Patch Set 2 : Can only test CrOS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -2 lines) Patch
M chrome/browser/resources/options/browser_options.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/pref_ui.js View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/options_browsertest.js View 1 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
michaelpg
6 years, 5 months ago (2014-07-18 18:26:01 UTC) #1
Evan Stade
lgtm
6 years, 5 months ago (2014-07-18 18:32:49 UTC) #2
michaelpg
The CQ bit was checked by michaelpg@chromium.org
6 years, 5 months ago (2014-07-18 18:38:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelpg@chromium.org/400993003/1
6 years, 5 months ago (2014-07-18 18:41:00 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-18 22:10:07 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-18 23:20:58 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/builds/53303)
6 years, 5 months ago (2014-07-18 23:20:59 UTC) #7
michaelpg
The CQ bit was checked by michaelpg@chromium.org
6 years, 5 months ago (2014-07-18 23:44:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelpg@chromium.org/400993003/20001
6 years, 5 months ago (2014-07-18 23:46:15 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-19 02:49:57 UTC) #10
Message was sent while issue was closed.
Change committed as 284292

Powered by Google App Engine
This is Rietveld 408576698