Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 400983004: ash: Fix a few leaks in the network list. (Closed)

Created:
6 years, 5 months ago by sadrul
Modified:
6 years, 5 months ago
Reviewers:
jennyz
CC:
chromium-reviews, stevenjb+watch_chromium.org, ben+ash_chromium.org, oshima+watch_chromium.org, kalyank
Project:
chromium
Visibility:
Public.

Description

ash: Fix a few leaks in the network list. View::RemoveChildView() does not delete the child view. So make sure they are destroyed correctly. BUG=none R=jennyz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284140

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M ash/system/chromeos/network/network_state_list_detailed_view.cc View 4 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sadrul
6 years, 5 months ago (2014-07-18 16:04:24 UTC) #1
jennyz
lgtm
6 years, 5 months ago (2014-07-18 17:10:52 UTC) #2
sadrul
6 years, 5 months ago (2014-07-18 17:36:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r284140 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698