Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 40095: Enable interstitial pages for SSL certificate errors on Linux. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 2 months ago by Markus (顧孟勤)
Modified:
6 years ago
Reviewers:
jcampan, Evan Martin
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Enable interstitial pages for SSL certificate errors on Linux. There are still problems with this patch, as acknowledging the interstitial page often fails to load a new page. Instead, it just displays a blank gray page. This appears to be somewhat timing related. Nonetheless, this changelist is strictly an improvement over what we have right now. So, I would still like to commit it. Ideally, I'd like to remove the special-case Windows code. But I don't have a Windows machine to check whether the new code is actually a full superset of the old Windows code. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=11177

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -15 lines) Patch
M chrome/browser/ssl/ssl_blocking_page.cc View 1 3 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/tab_contents/interstitial_page.cc View 1 5 chunks +18 lines, -10 lines 0 comments Download
Trybot results:
Commit queue not available (can’t edit this change).

Messages

Total messages: 4 (0 generated)
Markus (顧孟勤)
8 years, 2 months ago (2009-03-06 23:31:43 UTC) #1
Evan Martin
This doesn't look bad to me, but I don't know the code too well. Jay, ...
8 years, 2 months ago (2009-03-06 23:33:40 UTC) #2
Evan Martin
I will say LGTM and Jay can comment if he wants to later. :)
8 years, 2 months ago (2009-03-06 23:34:39 UTC) #3
jcampan
8 years, 2 months ago (2009-03-06 23:48:59 UTC) #4
LGTM
This probably should work on Windows.
Once you have checked-in I'll look into it.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06